Upgrade to Node 16 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wattenberger
reviewed
Mar 9, 2023
README.md
Outdated
| 1. `npm run dist` and commit the built output (yes, you read that right) | ||
| 2. Bump whatever you want to bump in the `package.json` version field | ||
| 3. Merge `main` into `vMAJOR` branch. `git checkout vMAJOR && git merge main` | ||
| 1. Set the `NODE_OPTIONS` environment variale to `--openssl-legacy-provider` |
There was a problem hiding this comment.
might it make more sense to bake this into the dist command? https://github.com/githubocto/flat/blob/main/package.json#LL10C14-L10C14
There was a problem hiding this comment.
Yes! I will update and test.
There was a problem hiding this comment.
Looks like this will require a little more work than I thought as Node versions 16 and lower do not like setting the --openssl-legacy-provider in NODE_OPTIONS
Wattenberger
reviewed
Mar 9, 2023
| @@ -0,0 +1,93 @@ | |||
| { | |||
There was a problem hiding this comment.
any idea why this adds a package.json file to the dist folder?
There was a problem hiding this comment.
Not sure! I will check across revisions and see what causes this.
|
Still working on this! |
|
Closing in favor of #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GitHub Actions is deprecating support for Node 12 support as Node 12 has gone out of support
This pull request updates
action.ymland dependency-related files for this Action to use Node 16 in line with GitHub recommendationsTesting
I changed one of my projects to use the updated version of the Action from my forked repo and ran the workflow that uses it, and the workflow completed successfully.
Todos
export NODE_OPTIONS=--openssl-legacy-providerto solve theERR_OSSL_EVP_UNSUPPORTEDbuild-time error.