feat: detailed error state handling

gitify-app · Apr 6, 2024 · 595e074 · 595e074
1 parent 79a1737
commit 595e074
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/utils/helpers.ts b/src/utils/helpers.ts
@@ -78,11 +78,14 @@ export function formatSearchQueryString(
 }
 
 export async function getHtmlUrl(url: string, token: string): Promise<string> {
-  const response: Issue | IssueComments | PullRequest = (
-    await apiRequestAuth(url, 'GET', token)
-  ).data;
-
-  return response.html_url;
+  try {
+    const response: Issue | IssueComments | PullRequest = (
+      await apiRequestAuth(url, 'GET', token)
+    ).data;
+    return response.html_url;
+  } catch (err) {
+    console.error('Failed to get html url');
+  }
 }
 
 export function getCheckSuiteUrl(notification: Notification) {
@@ -280,6 +283,10 @@ export async function generateGitHubWebUrl(
     }
   }
 
+  if (!url) {
+    url;
+  }
+
   url = addNotificationReferrerIdToUrl(url, notification.id, accounts.user?.id);
 
   return url;