Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: combine fetchNotifications effect #1012

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: combine fetchNotifications effect #1012

merged 1 commit into from
Apr 16, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Apr 16, 2024

Reduces the number of fetchNotification calls on startup by combining into a single useEffect hook

@setchy setchy added the bug Something isn't working label Apr 16, 2024
@setchy setchy added this to the Release 5.3.0 milestone Apr 16, 2024
afonsojramos
afonsojramos approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that certainly wasn't helping 😅

@afonsojramos afonsojramos merged commit 421b9dd into main Apr 16, 2024
6 of 7 checks passed
@afonsojramos afonsojramos deleted the fix/combine-fetchnotifications-effect branch April 16, 2024 13:28
@setchy setchy mentioned this pull request Apr 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos