Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle repository notification #1245

Merged
merged 2 commits into from
Jun 16, 2024
Merged

feat: toggle repository notification #1245

merged 2 commits into from
Jun 16, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 15, 2024

Closes #1243

Screenshot 2024-06-15 at 12 30 32 PM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 15, 2024
@setchy setchy added this to the Release 5.9.0 milestone Jun 15, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but I think the UX is a bit weird since the Chevron location is not consistent (account vs repository).

Do you think that putting it on the left would look weird? Also, I think that this should be the default behaviour for clicking the row itself, what do you think?

@setchy
Copy link
Member Author

setchy commented Jun 16, 2024

Do you think that putting it on the left would look weird?

i tried that and the indenting looks weird... we'd need to move both chevrons (Account and Repository) for consistency.

Also, I think that this should be the default behaviour for clicking the row itself, what do you think?

i like this suggestion - perhaps in a separate PR and applied to the Account and Repository rows. Or, we remove the chevron all together and just rely on this 🤷

@setchy setchy merged commit 096735c into main Jun 16, 2024
7 checks passed
@setchy setchy deleted the feat/repository-collapse branch June 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chevron on repository header to collapse all notifications
2 participants