Fix branch name encoding issue

[layzerar]

When the branch name contains non-ascii characters, it will raise a encoding error when viewing any commit of this branch.

Here is the detail of traceback.

Encoding::CompatibilityError (incompatible character encodings: UTF-8 and ASCII-8BIT):
  app/views/projects/commit/_commit_box.html.haml:47:in `_app_views_projects_commit__commit_box_html_haml__3615852107586763187_70120827707580'
  app/views/projects/commit/show.html.haml:1:in `_app_views_projects_commit_show_html_haml___1131168359666268760_70120827597420'
  app/controllers/application_controller.rb:57:in `set_current_user_for_thread'

  Rendered errors/encoding.html.haml within layouts/errors (0.1ms)
  Rendered layouts/_head.html.haml (1.4ms)
  Rendered layouts/_search.html.haml (1.4ms)
  Rendered layouts/_head_panel.html.haml (10.0ms)
  Rendered layouts/_flash.html.haml (0.2ms)
Completed 500 Internal Server Error in 526ms (Views: 12.4ms | ActiveRecord: 14.5ms)

[layzerar]

https://github.com/gitlabhq/gitlabhq/issues/4120

[layzerar]

It's better to treat the branch name as utf-8 than ascii.

Hm, how does this build failed?

[layzerar]

It's failed in ruby 1.9.3 but succeed in ruby 2.0. Does it concerned with this pull request?

[dosire]

@randx Lots of people are encountering problems with non-ascii branch names that this should fix. Can you review it?

[dzaporozhets]

We can use existing encoding helper output = EncodingHelper.encode!(output)?

[layzerar]

Sorry for commit three times. I'm really a novice to ruby. I'm test it with gitlab 6.5.1 in Ubuntu12.04. It works fine.

[dosire]

@layzerar Can you use the code @randx suggested? output = EncodingHelper.encode!(output)

[layzerar]

That's a really good solution.

[dosire]

@layzerar Can you adapt your PR?

[layzerar]

@dosire Yes. But I don't have test environment now. I'm afraid I couldn't change it until tomorrow.

[dosire]

@layzerar No problem, tomorrow is fine.

[layzerar]

I adapted the pull request just now. I tested it in my machine, it works fine.

[dosire]

@randx Looks good to me.

[dosire]

Thanks @randx and @layzerar