New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or prepend underscore _ to unused method arguments #7925

Merged
merged 1 commit into from Jan 15, 2015

Conversation

5 participants
@cirosantilli
Contributor

cirosantilli commented Sep 30, 2014

  • remove up_dir_path tree which can be removed
  • add underscore Devise callbacks to silence Hound in those cases where it cannot be omitted as mentioned at: #7858 (diff)
@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 30, 2014

I've prepared a stage. Click to open.

@@ -15,11 +15,11 @@ def build_resource(hash=nil)
super
end
def after_sign_up_path_for resource
def after_sign_up_path_for _resource

This comment has been minimized.

@houndci-bot

houndci-bot Sep 30, 2014

Use def with parentheses when there are parameters.

new_user_session_path
end
def after_inactive_sign_up_path_for resource
def after_inactive_sign_up_path_for _resource

This comment has been minimized.

@houndci-bot

houndci-bot Sep 30, 2014

Use def with parentheses when there are parameters.

@cirosantilli cirosantilli force-pushed the cirosantilli:unused-arguments branch from b802eaa to 77239f6 Sep 30, 2014

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Dec 13, 2014

@cirosantilli Can you please make this mergeable again?

@cirosantilli cirosantilli force-pushed the cirosantilli:unused-arguments branch from 77239f6 to 6c65b91 Dec 27, 2014

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Dec 27, 2014

Updated.

@cirosantilli cirosantilli changed the title from Remove or prepend underscore _ to unused method arguments to [WIP] Remove or prepend underscore _ to unused method arguments Dec 27, 2014

@cirosantilli cirosantilli changed the title from [WIP] Remove or prepend underscore _ to unused method arguments to Remove or prepend underscore _ to unused method arguments Dec 27, 2014

@jvanbaarsen jvanbaarsen added this to the 7.7 milestone Jan 4, 2015

@dzaporozhets dzaporozhets modified the milestones: 7.7, 7.8 Jan 13, 2015

dzaporozhets added a commit that referenced this pull request Jan 15, 2015

Merge pull request #7925 from cirosantilli/unused-arguments
Remove or prepend underscore _ to unused method arguments

@dzaporozhets dzaporozhets merged commit 1159157 into gitlabhq:master Jan 15, 2015

2 checks passed

default The build passed on Semaphore.
Details
semaphoreci The build passed on Semaphore.
Details
@dzaporozhets

This comment has been minimized.

Member

dzaporozhets commented Jan 15, 2015

Thanks

@cirosantilli cirosantilli deleted the cirosantilli:unused-arguments branch Jan 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment