Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or prepend underscore _ to unused method arguments #7925

Merged
merged 1 commit into from
Jan 15, 2015
Merged

Remove or prepend underscore _ to unused method arguments #7925

merged 1 commit into from
Jan 15, 2015

Conversation

cirosantilli
Copy link
Contributor

@TeatroIO
Copy link

I've prepared a stage. Click to open.

houndci-bot
houndci-bot reviewed Sep 30, 2014
View reviewed changes
app/controllers/registrations_controller.rb
@@ -15,11 +15,11 @@ def build_resource(hash=nil)
super
end

def after_sign_up_path_for resource
def after_sign_up_path_for _resource
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use def with parentheses when there are parameters.

@jvanbaarsen
Copy link
Contributor

@cirosantilli Can you please make this mergeable again?

@cirosantilli
Copy link
Contributor Author

Updated.

@cirosantilli cirosantilli changed the title Remove or prepend underscore _ to unused method arguments [WIP] Remove or prepend underscore _ to unused method arguments Dec 27, 2014
@cirosantilli cirosantilli changed the title [WIP] Remove or prepend underscore _ to unused method arguments Remove or prepend underscore _ to unused method arguments Dec 27, 2014
@jvanbaarsen jvanbaarsen added this to the 7.7 milestone Jan 4, 2015
@dzaporozhets dzaporozhets modified the milestones: 7.7, 7.8 Jan 13, 2015
dzaporozhets added a commit that referenced this pull request Jan 15, 2015
@dzaporozhets
Merge pull request #7925 from cirosantilli/unused-arguments
1159157 
Remove or prepend underscore _ to unused method arguments
@dzaporozhets dzaporozhets merged commit 1159157 into gitlabhq:master Jan 15, 2015
@dzaporozhets
Copy link
Member

Thanks

@cirosantilli cirosantilli deleted the unused-arguments branch January 16, 2015 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready for Merge
Milestone
7.8
Development

Successfully merging this pull request may close these issues.
5 participants
@cirosantilli @TeatroIO @jvanbaarsen @dzaporozhets @houndci-bot