Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button styles #52

Closed
Tracked by #1
chrifro opened this issue Mar 30, 2023 · 5 comments · Fixed by #65
Closed
Tracked by #1

Update button styles #52

chrifro opened this issue Mar 30, 2023 · 5 comments · Fixed by #65

Comments

@chrifro
Copy link
Contributor

chrifro commented Mar 30, 2023

I realised that the current button styles don't work so well so I tweaked them a bit. You can find the new styles here

@chrifro
Copy link
Contributor Author

chrifro commented Mar 30, 2023

The hover effect for the social icons should be a 30% overlay of white #FFFFFF [1]

@Siddhant-K-code
Copy link
Member

Resolved in c80f1c9

@chrifro
Copy link
Contributor Author

chrifro commented Mar 30, 2023

The hover effect for the social icons should be a 30% overlay of white #FFFFFF [1]

Did you fix this as well? @Siddhant-K-code

It's not updated in the preview yet
Bildschirm­foto 2023-03-30 um 13 54 19

@chrifro chrifro reopened this Mar 30, 2023
@chrifro
Copy link
Contributor Author

chrifro commented Mar 31, 2023

Instead of black, could we use a transparent bg color for this hover style? By that the button also works well on a blue background.

Bildschirm­foto 2023-03-31 um 09 06 24

@Siddhant-K-code
Copy link
Member

Instead of black, could we use a transparent bg color for this hover style? By that the button also works well on a blue background.

yes 🙃

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants