Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Check Bash completion and refactor #54

Merged
merged 3 commits into from
Mar 6, 2020
Merged

CI: Check Bash completion and refactor #54

merged 3 commits into from
Mar 6, 2020
+108 −16

Conversation

Kreyren
Copy link

@Kreyren Kreyren commented Mar 4, 2020

Currently bashlisa ignores bash completion since it does not end with **.bash -> this should fix it

@JesterOrNot
Copy link
Contributor

Why add gradelw?

JesterOrNot
JesterOrNot reviewed Mar 4, 2020
View reviewed changes
.github/workflows/bash.yml Outdated Show resolved Hide resolved
.github/workflows/bash.yml Outdated Show resolved Hide resolved
@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

@JesterOrNot because i already resolved this issue on https://github.com/Kreyren/revolution-irc and i forgot to change it

@JesterOrNot
Copy link
Contributor

Ok

@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

@JesterOrNot i will probably spam here (working with workflows is pita), feel free to unsubscribe i will ping you when it's ready

@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

credit #bash for pointing out pitfalls

@Kreyren Kreyren marked this pull request as ready for review March 4, 2020 20:27
@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

affected by koalaman/shellcheck#1771

Kreyren
Kreyren commented Mar 4, 2020
View reviewed changes
tools/dockerfreeze Outdated Show resolved Hide resolved
@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

@JesterOrNot Ready for review

@Kreyren Kreyren requested a review from JesterOrNot March 4, 2020 20:39
@Kreyren Kreyren changed the title DO_NOT_MERGE: bashilisa: Check Bash completion bashilisa: Check Bash completion Mar 4, 2020
@Kreyren
Copy link
Author

Kreyren commented Mar 4, 2020

DO_NOT_MERGE: i can resolve the issue with shellcheck

@Kreyren Kreyren changed the title bashilisa: Check Bash completion DO_NOT_MERGE: bashilisa: Check Bash completion Mar 4, 2020
@Kreyren
Copy link
Author

Kreyren commented Mar 5, 2020

Currently blocked by actions/checkout#175

@Kreyren
Copy link
Author

Kreyren commented Mar 5, 2020

@JesterOrNot Works now, ready for review

Kreyren
Kreyren commented Mar 5, 2020
View reviewed changes
tools/dockerfreeze Outdated Show resolved Hide resolved
JesterOrNot
JesterOrNot suggested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@JesterOrNot JesterOrNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase into one commit

@Kreyren Kreyren changed the title DO_NOT_MERGE: bashilisa: Check Bash completion bashilisa: Check Bash completion Mar 5, 2020
@Kreyren
Copy link
Author

Kreyren commented Mar 5, 2020

@JesterOrNot Please squash in case we need to backtrack issues

@JesterOrNot
Copy link
Contributor

Squashed

@JesterOrNot
Copy link
Contributor

Fixed commit description to remove the spam commit description

@Kreyren
Copy link
Author

Kreyren commented Mar 6, 2020

Squashed

I meant squash using GitHub so that we can keep the commits on the branch.. Well too late now.. >.>

@JesterOrNot
Copy link
Contributor

Sorry 😅

@Kreyren Kreyren changed the title bashilisa: Check Bash completion bashilisa: Check Bash completion and refactor Mar 6, 2020
@Kreyren Kreyren changed the title bashilisa: Check Bash completion and refactor CI: Check Bash completion and refactor Mar 6, 2020
@Kreyren
Copy link
Author

Kreyren commented Mar 6, 2020

@JesterOrNot Check again should be perfect now ^-^

@JesterOrNot JesterOrNot self-requested a review March 6, 2020 16:02
JesterOrNot
JesterOrNot suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@JesterOrNot JesterOrNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not *.sh files?

.github/workflows/bash.yml Show resolved Hide resolved
@JesterOrNot JesterOrNot self-requested a review March 6, 2020 16:36
@Kreyren
Copy link
Author

Kreyren commented Mar 6, 2020

@JesterOrNot anything else?

JesterOrNot
JesterOrNot approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@JesterOrNot JesterOrNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesterOrNot JesterOrNot merged commit 08cdea2 into gitpod-io:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesterOrNot JesterOrNot JesterOrNot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kreyren @JesterOrNot