Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Always Create Workspace with Options #15979

Closed
4 tasks done
svenefftinge opened this issue Jan 23, 2023 · 3 comments
Closed
4 tasks done

Epic: Always Create Workspace with Options #15979

svenefftinge opened this issue Jan 23, 2023 · 3 comments

Comments

@svenefftinge
Copy link
Member

svenefftinge commented Jan 23, 2023

Gitpod used to do the-right-thing™️ based on context URLs. I.e. if you throw a PR link at it it will checkout the corresponding branch, if it's an issue it will create a new branch, etc. This was cool and a bit magical (in both good and bad ways), but has become less good, with the variability we have introduced (workspace classes, editor, env variables, etc.).

Therefore we have introduced a start-with-options dialog that allows users to review and change the input parameters to a create-workspace call. So far you have to explicitly pass an argument to get that dialog, but we believe the dialog is helpful to communicate and have users approve how a workspace is created.

Always showing the create workspace dialog also allows for communicating under which organization the workspace is going to be started.

Proposal

Show the create workspace dialog by default to all workspace creation requests unless there is an explicit argument to skip it (i.e. turn the logic around). Do the context URL parsing to fill the dialog with information about what is going to happen, specifically what repo and branch the workspace is going to be started with. Allow users to change that and confirm.

Breakdown

Bugs

  1. meta: stale team: webapp type: bug
  2. component: dashboard needs visual design team: webapp type: bug
    svenefftinge
  3. component: dashboard component: server meta: stale type: bug
  4. component: dashboard component: server type: bug
    svenefftinge
@gtsiolis
Copy link
Contributor

+1 — Re-posting a relevant part from #15756 (comment) for visibility:

Alternatively, we could skip the step to select options when directly selecting a workspace from the workspaces list using the row or workspace ID, and keep the prompt in all other cases like:

  1. Workspace more actions dropdown
  2. Project cards more action dropdown
  3. Project branches new workspace button
  4. Prebuild new workspace button

@mbrevoort
Copy link
Contributor

mbrevoort commented Jan 23, 2023

This comment is very much related to this proposal

I believe that if a user ever starts or restarts, regardless of where they comes from, they should see a consistent and reliable interface. It should serve as:

  1. a confirmation of what is about to happen
  2. an opportunity to modify the parameters (editor, workspace class, etc.)
  3. an opportunity to cancel

I don't believe we need additional options in menus like "Open with options" or "Open ...". There should just be "Open" and this unified experience.

@geropl
Copy link
Member

geropl commented Mar 29, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Validation
Development

No branches or pull requests

4 participants