Gitpod tries to pull Theia image with a tag that does not exist

[corneliusludmann]

• See Can not open workspaces with Theia editor #4672
• I tagged eu.gcr.io/gitpod-core-dev/build/ide/theia@sha256:537433f51fc21561d117c65746601eed95a8f9e08d8d31e81b03defdea65e238 by hand with tag commit-f8da2b7b725c2a0949f904ead725763923b653ea, now it works
• We need to investigate why this missing tag happened in the first place

[meysholdt]

Probably not the cause, but it makes finding stuff a bit harder:
Commit f8da2b7b725c2a0949f904ead725763923b653ea is not on main

The build for commit ...53ea is gitpod-build-jh-track-user-deletion.0 and the Theia image is not part of the build results:

[meysholdt]

docker run eu.gcr.io/gitpod-core-dev/build/versions:jh-track-user-deletion.0 cat /versions.yaml returns

theiaImage:
      version: commit-195a305c297b4989e26d075f65f036f3bbfe34c6

Since that version is different from the one Cornelius posted, I suspect the cause is a config error: The Theia image is being pulled using a tag that was designated for a another image.

[meysholdt]

From the prod server k8s deployment:

        - name: SERVER_VERSION
          value: commit-f8da2b7b725c2a0949f904ead725763923b653ea
(...)
        - name: THEIA_IMAGE_REPO
          value: eu.gcr.io/gitpod-core-dev/build/ide/theia

It looks like the Theia image is using the server-version.

gitpod/chart/templates/server-deployment.yaml

Lines 142 to 149 in ce50d2a

	- name: SERVER_VERSION
	value: "{{ template "gitpod.comp.version" $this }}"
	- name: SHLVL
	value: "1"
	- name: THEIA_PORT
	value: "{{ .Values.components.workspace.ports.http.containerPort | toString }}"
	- name: THEIA_IMAGE_REPO
	value: "{{ template "gitpod.comp.imageRepo" (dict "root" . "gp" $.Values "comp" .Values.components.workspace.theiaImage) }}"

The server should obtain+use the Theia-version.

[corneliusludmann]

Indeed, it takes the server version as fallback whenthe Theia version is not set:

gitpod/components/server/src/env.ts

Lines 35 to 38 in 0bf71f1

	readonly theiaVersion = process.env.THEIA_VERSION || this.serverVersion;
	readonly theiaImageRepo = process.env.THEIA_IMAGE_REPO || 'unknown';
	readonly theiaMounted = process.env.THEIA_MOUNTED === "true";
	readonly ideDefaultImage = `${this.theiaImageRepo}:${this.theiaVersion}`;