No logs for short prebuilds

[AlexTugarev]

If a prebuild is very short, i.e. doesn't take a while to be built, it appears to not be shown with logs and logs are not persisted in the storage.

How to reproduce? Just create a project for a not yet configured repo in your account and use the simples echo something template form the project configurator.

[AlexTugarev]

cc. @geropl, because he already had a suspicion about this.

#5570 (comment)

[geropl]

Could a1da634 be the cause?
We no longer wait for c.State.Running == nil for the workspace container, which includes proper shutdown of supervisor, including writing of terminal logs. @csweichel

[csweichel]

/schedule

[roboquat]

@csweichel: Issue scheduled in the workspace team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[geropl]

Should be fixed with this one: #5897

[AlexTugarev]

@geropl, I'm afraid this is not the case

Should be fixed with this one: #5897

[geropl]

A quick tests with https://github.com/geropl/test-repo revealed that for short prebuilds:

• there is no workspace backup
• there is no logs uploaded

I will try to find the reason, but think this is a workspace issue 😕

Update: I found that DisposeWorkspace is never called, but have no clue why. Create #6435

[geropl]

Not actively working on this.