Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetching repositories loading state #12833

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Sep 9, 2022

Description

This will update the loading state when fetching repositories, and GitLab groups or GitHub orgs, based on the comment in #5075 (comment), using the same pattern we use in fetching repository branches and prebuilds within a project.

Related Issue(s)

Related to #5075

How to test

  1. Try adding a new project

Screenshots

BEFORE AFTER
Screenshot 2022-09-09 at 4 48 32 PM (2) Screenshot 2022-09-09 at 4 48 44 PM (2)

Release Notes

Improve fetching repositories loading state

Werft options:

  • /werft with-preview

@gtsiolis gtsiolis requested a review from a team September 9, 2022 13:53
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 9, 2022
@roboquat roboquat merged commit 6635528 into main Sep 12, 2022
@roboquat roboquat deleted the gt/improve-fetching-repositories branch September 12, 2022 06:16
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 12, 2022

Thanks for taking a look, @svenefftinge! ⛵

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants