dev/preview:build: Clean git repository before performing build #14156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional build args
vulkoingim
reviewed
Oct 25, 2022
| # We should fix the package definitions so that they don't include these files in the hash. | ||
| # | ||
| # For now we're simply cleaning the repository by deleting all files that are in .gitignore. | ||
| git clean -dfX |
There was a problem hiding this comment.
Let's do this only in werft, as otherwise it might nuke changes/files that have not been added yet if you run it from a ws
Suggested change
| git clean -dfX | |
| if [[ -n ${WERFT_SERVICE_HOST+x} ]]; then | |
| git clean -dfX | |
| fi |
There was a problem hiding this comment.
This is only really needed outside of Werft though - I don't think it will remove changed files (will test), but you're right it would delete files that are not yet tracked by git! Let me see if I can't narrow it down to only cover "ignored files"
vulkoingim
approved these changes
Oct 25, 2022
| # The files were produced using "git clean -ndfX" | ||
| components_dir="$SCRIPT_PATH/../../../../components" | ||
| install_dir="$SCRIPT_PATH/../../../../install" | ||
| rm -rf \ |
There was a problem hiding this comment.
It's an ephemeral workspace, what's the worst that could happen 😉 Kidding aside, I'm only okay with this because we're going to remove it soon when we fix the real issue in #14157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that the "cache miss" we were seeing from Gitpod Workspaces is due to some of our packages being sensitive to a "dirty filesystem". As a temporary solution I'm using
git clean(see comment in code) but we should go through each component and see if we can make sure it isn't impacted by the occurrence of files that we have in .gitignore (such as build folders) - I have created an issue (#14157) and proposed it for next week.This PR also adds a few more build arguments to align with the Leeway invocation performed by Werft to make it easier to merge the two as part of https://github.com/gitpod-io/ops/issues/5894
Related Issue(s)
Fixes #13767
How to test
Release Notes
Documentation
N/A
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide