Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Update go to 1.16.3 #3820

Merged
merged 2 commits into from
Apr 8, 2021
Merged

[dev] Update go to 1.16.3 #3820

merged 2 commits into from
Apr 8, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 7, 2021 •
edited
Loading

  • Update go version to 1.16.3
  • Adjust go build flags

Why? Using pprof to find a leak (#3108) I found that it was not possible to use pprof list

before this change

goroutine profile: total 31
1 @ 0x40c6f4 0x46e545 0x19e2265 0x471e61
#	0x46e544	os/signal.signal_recv+0xa4	/home/gitpod/sdk/go1.16/src/runtime/sigqueue.go:168
#	0x19e2264	os/signal.loop+0x24		/home/gitpod/sdk/go1.16/src/os/signal/signal_unix.go:23

1 @ 0x43aec5 0x4068cf 0x40650b 0x1923b13 0x180be8e 0x180bf51 0x471e61
#	0x1923b12	k8s.io/client-go/tools/cache.(*sharedProcessor).run+0x52		/workspace/go/pkg/mod/k8s.io/client-go@v0.20.4/tools/cache/shared_informer.go:628
#	0x180be8d	k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel.func1+0x2d	/workspace/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:56
#	0x180bf50	k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1+0x50		/workspace/go/pkg/mod/k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:73

after

goroutine profile: total 162
100 @ 0x43aec5 0x44bfd7 0x16a20e8 0x16a1c57 0x471e01
#	0x16a20e7	github.com/gitpod-io/gitpod/ws-manager/pkg/manager/internal/workpool.(*EventWorkerPool).work+0x447		github.com/gitpod-io/gitpod/ws-manager/pkg/manager/internal/workpool/workpool.go:149
#	0x16a1c56	github.com/gitpod-io/gitpod/ws-manager/pkg/manager/internal/workpool.(*EventWorkerPool).workUntilStopped+0x56	github.com/gitpod-io/gitpod/ws-manager/pkg/manager/internal/workpool/workpool.go:99

3 @ 0x43aec5 0x4068cf 0x40650b 0x16b34d3 0xd8b84e 0xd8b911 0x471e01
#	0x16b34d2	k8s.io/client-go/tools/cache.(*sharedProcessor).run+0x52		k8s.io/client-go@v0.20.4/tools/cache/shared_informer.go:628
#	0xd8b84d	k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel.func1+0x2d	k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:56
#	0xd8b910	k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1+0x50		k8s.io/apimachinery@v0.20.4/pkg/util/wait/wait.go:73

3 @ 0x43aec5 0x4068cf 0x40650b 0x16b7d94 0x471e01
#	0x16b7d93	k8s.io/client-go/tools/cache.(*controller).Run.func1+0x33	k8s.io/client-go@v0.20.4/tools/cache/controller.go:130

@aledbf aledbf marked this pull request as ready for review April 7, 2021 15:52
@aledbf aledbf requested a review from csweichel April 7, 2021 15:53
@aledbf aledbf force-pushed the aledbf/go163 branch 3 times, most recently from 860b234 to 46f13ec Compare April 7, 2021 21:12
@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-go163.6

@aledbf aledbf force-pushed the aledbf/go163 branch 3 times, most recently from 626c1e0 to 605b1ca Compare April 7, 2021 21:35
@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-go163.12

@aledbf aledbf force-pushed the aledbf/go163 branch 3 times, most recently from 67d211b to d56b26b Compare April 7, 2021 22:12
@aledbf
Copy link
Member Author

aledbf commented Apr 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-go163.17

@aledbf aledbf force-pushed the aledbf/go163 branch 11 times, most recently from 5cb7507 to e04d721 Compare April 8, 2021 00:12
@aledbf aledbf mentioned this pull request Apr 8, 2021
Closed
24 tasks
@aledbf aledbf requested a review from csweichel April 8, 2021 10:38
csweichel
csweichel approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update

@aledbf aledbf merged commit 7d934f6 into main Apr 8, 2021
@aledbf aledbf deleted the aledbf/go163 branch April 8, 2021 10:57
@aledbf aledbf mentioned this pull request Apr 9, 2021
Merged
@jankeromnes jankeromnes mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledbf @csweichel