[dashboard] Standardize PendingChangesDropdown component in workspaces list (replaces Modal) and stopped page (unchanged)

[jankeromnes]

Align with spec and side effect fix for dark theme:

[jankeromnes]

Currently looks like this:

Problems to fix:

• Vertical alignment is off
• Clicking on it doesn't work

[jankeromnes]

Now looks like this:

[jankeromnes]

@gtsiolis could you please take a look, and make a final decision? 🙏

• Either we go with this PR, replacing the Changes Modal with a dropdown

• Or we temporarily park this PR to keep the Changes Modal, and simply adjust the balloon colors for dark theme, and fix the Modal-induced scrollbar

[gtsiolis]

/werft run

👍 started the job as gitpod-build-jx-workspaces-changes-dropdown.3

[gtsiolis]

Looking at this now! 👀 Postponed, will take a look in an hour or so.

[jankeromnes]

Probably not critical for the release tomorrow (since dark theme is soft-launch, and there will probably be other small things to fix here and there 😇).

So: no rush 🌴

[gtsiolis]

Thanks for aligning this @jankeromnes! UX looks good! 🌟

Alright, I think this looks good to merge as is! We could probably add some hover and focus states on this new changes dropdown but this is certainly out of the scope of this PR.

[gtsiolis]

praise: Deleted code is the best code! 💯

[gtsiolis]

Either we go with this PR, replacing the Changes Modal with a dropdown
...

Sounds like a good plane for now! 🗺️

---

Posting this here for future reference:

Also, this seems like a good two-way door decision which allows us to come back and reverse this change in the future! 🔮

[jankeromnes]

Awesome, many thanks for the review! Then let's go forward with unifying this, but I'm more than happy to re-introduce a Changes Modal later. 🚀