Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-proxy] redirect HTTP to HTTPS #4138

Merged
merged 1 commit into from
May 4, 2021
Merged

[ws-proxy] redirect HTTP to HTTPS #4138

merged 1 commit into from
May 4, 2021

Conversation

AlexTugarev
Copy link
Member

This PR removes the useHTTPS switch from ws-proxy by making HTTPS termination enabled by default.

The redirect of HTTP requests should fix #4124.

@AlexTugarev AlexTugarev marked this pull request as draft May 4, 2021 08:49
.werft/values.dev.yaml Outdated Show resolved Hide resolved
.werft/values.dev.yaml Outdated Show resolved Hide resolved
@AlexTugarev AlexTugarev marked this pull request as ready for review May 4, 2021 09:08
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR itself works and is ready to merge. But we have to adjust downstream as well, especially the helm config.

@AlexTugarev AlexTugarev merged commit 70097b6 into main May 4, 2021
@AlexTugarev AlexTugarev deleted the at/proxy branch May 4, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask redirects timing out in workspaces
2 participants