Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor span log helpers #4384

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Refactor span log helpers #4384

merged 1 commit into from
Jun 3, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 3, 2021

Dropped 183 nodes (cum <= 3.61MB)
Showing top 10 nodes out of 25
      flat  flat%   sum%        cum   cum%
  318.73MB 44.16% 44.16%   318.73MB 44.16%  github.com/uber/jaeger-client-go.(*Span).appendLogNoLocking (inline)
  192.51MB 26.67% 70.83%   486.61MB 67.41%  github.com/gitpod-io/gitpod/common-go/tracing.LogEvent (inline)
  184.01MB 25.49% 96.32%   208.64MB 28.90%  github.com/gitpod-io/gitpod/common-go/tracing.LogKV (inline)
    1.50MB  0.21% 96.53%     4.02MB  0.56%  k8s.io/api/core/v1.(*Container).Unmarshal
         0     0% 96.53%   695.26MB 96.32%  github.com/gitpod-io/gitpod/ws-manager/pkg/manager.(*Monitor).actOnPodEvent.func2
         0     0% 96.53%   695.26MB 96.32%  github.com/gitpod-io/gitpod/ws-manager/pkg/manager.(*Monitor).probeWorkspaceReady
         0     0% 96.53%   695.26MB 96.32%  github.com/gitpod-io/gitpod/ws-manager/pkg/manager.(*Monitor).waitForWorkspaceReady
         0     0% 96.53%   695.26MB 96.32%  github.com/gitpod-io/gitpod/ws-manager/pkg/manager.(*WorkspaceReadyProbe).Run
         0     0% 96.53%    10.27MB  1.42%  github.com/gogo/protobuf/proto.Unmarshal
         0     0% 96.53%   318.73MB 44.16%  github.com/uber/jaeger-client-go.(*Span).LogFields

xref: #4106

@aledbf aledbf requested a review from csweichel June 3, 2021 03:12
@csweichel csweichel marked this pull request as ready for review June 3, 2021 13:20
@aledbf aledbf merged commit 660c7ec into main Jun 3, 2021
@aledbf aledbf deleted the aledbf/spanlog branch June 3, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants