Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable custom timeout errors in supervisor workspace web socket proxy #4404

Merged
merged 1 commit into from
Jun 8, 2021
Merged

disable custom timeout errors in supervisor workspace web socket proxy #4404

merged 1 commit into from
Jun 8, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 7, 2021 •
edited
Loading

What it does

How to test

You can try to reproduce below first in production.

  • Start a workspace.
  • Open the network tab in devtools, select web sockets.
  • Enable 3G network profile on system level, on Mac you can use https://nshipster.com/network-link-conditioner/
  • Reload the page, you should see that 2 web sockets to workspace is eventually connected. Ignore web sockets to gitpod.io and localhost.
  • Do it several times.
  • As a bonus try on Edge connection, you should never get a dialog with TIMEOUT error and after many attempts 2 web socket connection will be established.

@akosyakov akosyakov marked this pull request as ready for review June 7, 2021 08:21
svenefftinge
svenefftinge approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the timeout error with this anymore

@akosyakov akosyakov merged commit b207e31 into main Jun 8, 2021
@akosyakov akosyakov deleted the akosyakov/code-the-workbench-failed-3782 branch June 8, 2021 03:21
@akosyakov akosyakov mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

@csweichel csweichel Awaiting requested review from csweichel

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Code] The workbench failed to connect to the server (Error: TIMEOUT)
2 participants
@akosyakov @svenefftinge