Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] fix caching Not Found as OTS token #4577

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 23, 2021

What it does

Gitpod Server OTS token expires after some time. If the workspace startup takes a while for some reasons then the supervisor gets Not Found, but since it does not check http status code it cached Not Found as a token. Triggering all kind of frontend issues consequently:

Screenshot 2021-06-23 at 10 55 25

How to test

Not sure. Expiration time is quite high, I don't understand how supervisor manages to miss the token.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #4577 (3127021) into main (5f45aa7) will increase coverage by 36.63%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4577       +/-   ##
=========================================
+ Coverage      0   36.63%   +36.63%     
=========================================
  Files         0       15       +15     
  Lines         0     3775     +3775     
=========================================
+ Hits          0     1383     +1383     
- Misses        0     2277     +2277     
- Partials      0      115      +115     
Flag Coverage Δ
components-supervisor-app 36.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 25.70% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 76.00% <0.00%> (ø)
components/supervisor/pkg/ports/ports-config.go 79.85% <0.00%> (ø)
components/supervisor/pkg/supervisor/supervisor.go 0.00% <0.00%> (ø)
...mponents/supervisor/pkg/supervisor/notification.go 83.95% <0.00%> (ø)
components/supervisor/pkg/supervisor/tasks.go 47.97% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/supervisor/pkg/dropwriter/dropwriter.go 73.46% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 61.53% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f45aa7...3127021. Read the comment docs.

@akosyakov akosyakov requested a review from csweichel June 23, 2021 06:19
@akosyakov akosyakov merged commit 9ab3b02 into main Jun 23, 2021
@akosyakov akosyakov deleted the ak/fix_not_found_as_token branch June 23, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants