Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-scheduler] Respect pod slots when scheduling #4744

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

csweichel
Copy link
Contributor

This PR makes ws-scheduler respect the pod slots available on a node.

fixes #4700

@csweichel csweichel requested review from geropl, a team and aledbf and removed request for a team July 8, 2021 09:47
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #4744 (5549736) into main (8f0c24a) will increase coverage by 13.87%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4744       +/-   ##
===========================================
+ Coverage   48.80%   62.68%   +13.87%     
===========================================
  Files          30        9       -21     
  Lines        6661     1790     -4871     
===========================================
- Hits         3251     1122     -2129     
+ Misses       3163      597     -2566     
+ Partials      247       71      -176     
Flag Coverage Δ
components-ee-ws-scheduler-app 62.68% <95.23%> (+0.48%) ⬆️
components-local-app-app-darwin ?
components-local-app-app-linux ?
components-local-app-app-windows ?
components-ws-manager-app ?
components-ws-proxy-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/ee/ws-scheduler/pkg/scheduler/strategy.go 58.69% <94.11%> (+2.88%) ⬆️
components/ee/ws-scheduler/pkg/scheduler/state.go 90.46% <100.00%> (+0.09%) ⬆️
components/ws-manager/pkg/manager/manager_ee.go
components/ws-manager/pkg/manager/create.go
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
...omponents/ws-manager/pkg/manager/pod_controller.go
components/ws-proxy/pkg/proxy/workspacerouter.go
components/ws-proxy/pkg/proxy/infoprovider.go
components/ws-proxy/pkg/proxy/config.go
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0c24a...5549736. Read the comment docs.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, unit tests run: ✔️

@csweichel csweichel merged commit 28ea624 into main Jul 8, 2021
@csweichel csweichel deleted the cw/scheduler-pod-slots branch July 8, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-scheduler] Take pod resource into account
2 participants