Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Add unit tests for task composition #4903

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

csweichel
Copy link
Contributor

This PR adds a bunch of unit tests to ensure we're executing the correct set of tasks given any workspace setting.

fixes #4838

@csweichel
Copy link
Contributor Author

csweichel commented Jul 22, 2021

/werft run no-preview

👍 started the job as gitpod-build-csweichel-init-not-working-as-expected-4838.1

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #4903 (e22229c) into main (08a23d9) will increase coverage by 32.92%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4903       +/-   ##
=========================================
+ Coverage      0   32.92%   +32.92%     
=========================================
  Files         0       69       +69     
  Lines         0    13735    +13735     
=========================================
+ Hits          0     4522     +4522     
- Misses        0     8797     +8797     
- Partials      0      416      +416     
Flag Coverage Δ
components-content-service-app 14.46% <ø> (?)
components-content-service-lib 14.46% <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-supervisor-app 36.98% <93.75%> (?)
components-ws-daemon-app 22.29% <ø> (?)
components-ws-manager-app 36.81% <ø> (?)
components-ws-proxy-app 67.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/tasks.go 55.22% <93.75%> (ø)
components/content-service/pkg/storage/noop.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
...onents/content-service/pkg/service/blob-service.go 0.00% <0.00%> (ø)
components/image-builder/pkg/resolve/resolve.go 34.44% <0.00%> (ø)
components/ws-proxy/pkg/proxy/pass.go 76.85% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 79.05% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a23d9...e22229c. Read the comment docs.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81b40d2ba1e621ad60a744ac5375c0bb66c544a5

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ac7529f into main Jul 23, 2021
@roboquat roboquat deleted the csweichel/init-not-working-as-expected-4838 branch July 23, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init not working as expected with pre-build
3 participants