Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Log error if is not related to ErrBucketNotExist #4953

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 26, 2021

Screenshot from 2021-07-26 09-14-24

@roboquat roboquat requested a review from rl-gitpod July 26, 2021 13:14
@aledbf aledbf changed the title [content-service] Only log gcp error if is not related to ErrBucketNo… [content-service] Log error if is not related to ErrBucketNotExist Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #4953 (221327b) into main (89db73e) will increase coverage by 31.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4953       +/-   ##
=========================================
+ Coverage      0   31.09%   +31.09%     
=========================================
  Files         0       71       +71     
  Lines         0    14729    +14729     
=========================================
+ Hits          0     4580     +4580     
- Misses        0     9731     +9731     
- Partials      0      418      +418     
Flag Coverage Δ
components-content-service-app 14.45% <0.00%> (?)
components-content-service-lib 14.45% <0.00%> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 6.53% <ø> (?)
components-supervisor-app 36.82% <ø> (?)
components-ws-daemon-app 22.30% <ø> (?)
components-ws-manager-app 36.52% <ø> (?)
components-ws-proxy-app 67.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/content-service/pkg/storage/gcloud.go 3.10% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
...ontent-service/pkg/service/headless-log-service.go 24.13% <0.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/content-service/pkg/storage/namedurl.go 0.00% <0.00%> (ø)
components/content-service/pkg/archive/tar.go 60.31% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89db73e...221327b. Read the comment docs.

@csweichel
Copy link
Contributor

/LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea514195fbc3351998becff6ad86dbb59acb6384

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit c1eade3 into main Jul 26, 2021
@roboquat roboquat deleted the aledbf/dbucket branch July 26, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants