-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Adjust probe InitialDelaySeconds value #5163
Conversation
/assign @csweichel |
Makes sense to wait a bit initially. I'm not sure that it's always five seconds - in cases where it's not we're giving away workspace startup time. Personally I'd choose a slightly lower time, e.g. 2 seconds for this very reason. |
done |
/werft run 👍 started the job as gitpod-build-aledbf-probe.2 |
@csweichel build is fixed now. |
Codecov Report
@@ Coverage Diff @@
## main #5163 +/- ##
===========================================
+ Coverage 19.44% 36.34% +16.90%
===========================================
Files 14 13 -1
Lines 2510 3750 +1240
===========================================
+ Hits 488 1363 +875
- Misses 1960 2272 +312
- Partials 62 115 +53
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/lgtm |
LGTM label has been added. Git tree hash: b7d7af427f5c17801f99f04cb7b2601b2dacbb13
|
/werft run 👍 started the job as gitpod-build-aledbf-probe.4 |
/assign @akosyakov |
@akosyakov searching for an /approve :) |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue requirement bypassed by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We know that it takes at least five seconds. Do not log four errors (at least) per workspace.
Internal link https://cloudlogging.app.goo.gl/B64q9nYtXMBBHZiMA