Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Adjust probe InitialDelaySeconds value #5163

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 12, 2021

We know that it takes at least five seconds. Do not log four errors (at least) per workspace.

Internal link https://cloudlogging.app.goo.gl/B64q9nYtXMBBHZiMA

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

Makes sense to wait a bit initially. I'm not sure that it's always five seconds - in cases where it's not we're giving away workspace startup time. Personally I'd choose a slightly lower time, e.g. 2 seconds for this very reason.

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

Makes sense to wait a bit initially. I'm not sure that it's always five seconds - in cases where it's not we're giving away workspace startup time. Personally I'd choose a slightly lower time, e.g. 2 seconds for this very reason.

done

@csweichel
Copy link
Contributor

csweichel commented Aug 12, 2021

/werft run

👍 started the job as gitpod-build-aledbf-probe.2

@roboquat roboquat added size/S and removed size/XS labels Aug 12, 2021
@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

@csweichel build is fixed now.

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5163 (b811852) into main (8f867ae) will increase coverage by 16.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5163       +/-   ##
===========================================
+ Coverage   19.44%   36.34%   +16.90%     
===========================================
  Files          14       13        -1     
  Lines        2510     3750     +1240     
===========================================
+ Hits          488     1363      +875     
- Misses       1960     2272      +312     
- Partials       62      115       +53     
Flag Coverage Δ
components-workspacekit-app ?
components-ws-daemon-app ?
components-ws-manager-app 36.34% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/create.go 78.83% <100.00%> (ø)
components/ws-daemon/pkg/content/tar.go
components/workspacekit/cmd/rings.go
components/ws-daemon/pkg/content/config.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/internal/session/store.go
components/workspacekit/cmd/root.go
components/workspacekit/cmd/lift.go
components/ws-daemon/pkg/resources/dispatch.go
components/ws-daemon/pkg/resources/controller.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f867ae...b811852. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 12, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7d7af427f5c17801f99f04cb7b2601b2dacbb13

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/werft run

👍 started the job as gitpod-build-aledbf-probe.4

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @akosyakov

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

@akosyakov searching for an /approve :)

@aledbf
Copy link
Member Author

aledbf commented Aug 13, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 6f15a43 into main Aug 13, 2021
@roboquat roboquat deleted the aledbf/probe branch August 13, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants