-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-daemon] Refactor containerd error handling #5221
Conversation
/assign @geropl |
Code looks good. Waiting for the build/preview env to perform a basic test. |
Codecov Report
@@ Coverage Diff @@
## main #5221 +/- ##
=========================================
+ Coverage 0 23.05% +23.05%
=========================================
Files 0 11 +11
Lines 0 1926 +1926
=========================================
+ Hits 0 444 +444
- Misses 0 1423 +1423
- Partials 0 59 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the preview env finally deployed I tested:
- starting a workspace
- killing containerd on the node
✔️
LGTM label has been added. Git tree hash: 616ffee2926cab91d4a0112daf03bfcb5c58d999
|
/approve no-issue |
1 similar comment
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, geropl Associated issue requirement bypassed by: aledbf, geropl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.