[ws-man-bridge] don't update stopped workspaces #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back to stopping.
|
/lgtm |
|
LGTM label has been added. Git tree hash: b090e797a0bcb62d66bc46adaee4d75c30d611f8
|
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JanKoehnlein Associated issue requirement bypassed by: JanKoehnlein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws-manager-bridgecurrently resets already stopped workspaces to stopping. This breaks the user experience as users cannot start a stopping workspace.I don't believe this is only a race within a few seconds but have seen long stopped workspaces getting rest to 'stopping'. So this doesn't solve the root cause but just makes sure users are able to start their workspaces again.
Also #5223 is an attempt to solve the ordering of phases in a more holistic way. It doesn't seem to be complete yet, through.