Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable kube-health-monitor #5267

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Add option to disable kube-health-monitor #5267

merged 2 commits into from
Aug 19, 2021

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Aug 19, 2021

Fixes #5265

Add an option to our helm chart to disable kube-health-monitor.

Dev-Loop:

  • run docker run --rm --privileged --pid=host ubuntu /usr/bin/nsenter -t "1" -a bash -c "$(cat stop.sh)" on a node with stop.sh being the bash snippet from this PR.

Testing

  • /werft with-clean-slate-deployment

@geropl
Copy link
Member

geropl commented Aug 19, 2021

/werft run

👍 started the job as gitpod-build-me-health.3

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: e834dd13a1f97629437eb5957a497951b015edce

@meysholdt
Copy link
Member Author

Why does @roboquat try to summon Lorenzo?

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, wulfthimm

Associated issue: #5265

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit eb6fc26 into main Aug 19, 2021
@roboquat roboquat deleted the me/health branch August 19, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally disable kube-health-monitor.sh
4 participants