Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messages #5270

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Update error messages #5270

merged 1 commit into from
Aug 19, 2021

Conversation

YauhenPylAurea
Copy link
Contributor

@YauhenPylAurea YauhenPylAurea commented Aug 19, 2021

It seems that the existing error messages are not properly set up.

/approve no-issue

It seems that the existing error messages are not properly set up.
@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 19, 2021

Thanks for contributing @YauhenPylAurea! 🧡

@aledbf could you take a look at this when you're free?

@gtsiolis gtsiolis requested a review from aledbf August 19, 2021 12:37
@aledbf
Copy link
Member

aledbf commented Aug 19, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57f59a80a2fbd2dff40a7d17bcf42ddeb0c7a4cd

@aledbf
Copy link
Member

aledbf commented Aug 19, 2021

@YauhenPylAurea please keep in mind image-builder is being replaced by image-builder-mk3

@gtsiolis
Copy link
Contributor

/approve no-issue

@gtsiolis gtsiolis closed this Aug 19, 2021
@gtsiolis gtsiolis reopened this Aug 19, 2021
@gtsiolis
Copy link
Contributor

/approve no-issue

1 similar comment
@gtsiolis
Copy link
Contributor

/approve no-issue

@gtsiolis
Copy link
Contributor

/unhold

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 19, 2021

/werft run

👍 started the job as gitpod-build-patch-1.3

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aledbf, gtsiolis

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #5270 (7c56472) into main (eb6fc26) will increase coverage by 34.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5270       +/-   ##
=========================================
+ Coverage      0   34.44%   +34.44%     
=========================================
  Files         0        1        +1     
  Lines         0       90       +90     
=========================================
+ Hits          0       31       +31     
- Misses        0       55       +55     
- Partials      0        4        +4     
Flag Coverage Δ
components-image-builder-app 34.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/image-builder/pkg/resolve/resolve.go 34.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6fc26...7c56472. Read the comment docs.

@roboquat roboquat merged commit 0e160f2 into gitpod-io:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants