Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Ensure status before setting phase tag #5294

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 20, 2021

SA5011(related information): this check suggests that the pointer can be nil (staticcheck)go-golangci-lint

@aledbf
Copy link
Member Author

aledbf commented Aug 20, 2021

/assign @akosyakov

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve no-issue

@roboquat roboquat added the lgtm label Aug 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67f667ef22d78082db6db9674cbbfbd8b5f5edfc

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 18f1188 into main Aug 23, 2021
@roboquat roboquat deleted the aledbf/tag branch August 23, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants