Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpc-js library #5455

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Upgrade grpc-js library #5455

merged 2 commits into from
Aug 31, 2021

Conversation

princerachit
Copy link
Contributor

A recent bug fix was made to grpc-js library 1.3.7 release which fixes issue of connection closure. This can potentially fix #5414

@aledbf
Copy link
Member

aledbf commented Aug 31, 2021

@princerachit how did you update the dependency? (I don't see any change to yarn.lock)

@meysholdt
Copy link
Member

@aledbf I've added the update of the yarn.lock.

@aledbf
Copy link
Member

aledbf commented Aug 31, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 476b65dc47fc789937ca5be0e7bcd88c20bd3ad4

@aledbf
Copy link
Member

aledbf commented Aug 31, 2021

/assign @csweichel

@meysholdt
Copy link
Member

/approve

2 similar comments
@geropl
Copy link
Member

geropl commented Aug 31, 2021

/approve

@csweichel
Copy link
Contributor

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel, geropl, meysholdt

Associated issue: #5414

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4d9754e into main Aug 31, 2021
@roboquat roboquat deleted the prs/upgrade-grpc-js branch August 31, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEADLINE_EXCEEDED: gRPC communication trouble
6 participants