Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Refactor mark unmount #5469

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[ws-daemon] Refactor mark unmount #5469

merged 1 commit into from
Sep 1, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 1, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Sep 1, 2021

/schedule

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

@aledbf: We have more than 18 cards scheduled. Above 0 only scheduler can perform this action. Those are:

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member Author

aledbf commented Sep 1, 2021

/assign

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #5469 (621a377) into main (0cb6553) will increase coverage by 2.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5469      +/-   ##
==========================================
+ Coverage   19.39%   22.34%   +2.94%     
==========================================
  Files           2       11       +9     
  Lines         165     1947    +1782     
==========================================
+ Hits           32      435     +403     
- Misses        131     1454    +1323     
- Partials        2       58      +56     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-ws-daemon-app 22.34% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/ws-daemon/pkg/resources/controller.go 31.06% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 46.71% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb6553...621a377. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Sep 1, 2021

/assign @csweichel

@aledbf aledbf force-pushed the aledbf/unmount branch 9 times, most recently from 72de90b to de7204f Compare September 1, 2021 06:41
@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 1, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

LGTM label has been added.

Git tree hash: 37d0b66e9b014c646b258e035475c6015119e8ba

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ed48ca5 into main Sep 1, 2021
@roboquat roboquat deleted the aledbf/unmount branch September 1, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants