Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dei): he -> [they|their] #5581

Merged
merged 1 commit into from
Sep 20, 2021
Merged

chore(dei): he -> [they|their] #5581

merged 1 commit into from
Sep 20, 2021

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Sep 8, 2021

NONE

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghuntley! 🏀

We could probably remove the changed comment but there are a couple more which could be part of this PR. What do you think?

* - Chargebee subscription cancelled:
* - terminate the Gitpod subscription to the end of current billing period because we want the user to retain the credits he already paid for
* We calculate it to one month after current billing period started because the Chargebee Subscription does not carry any information about this

* Creates the following invariants on the given set of Subscriptions:
* - A user is granted a FREE subscription iff he has no paid subscription
* - For any given time from user.creationDate until forever the user has at least one subscription
* TODO Handle mis-use: Only grant a user FREE.hours par Month at most

* A user may open private repos if he either:
* - not started his free "priate repo trial" yet
* - is has been no longer than 30 days since he started his "priate repo trial"
* A user may open private repos if they either:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: We recently changed this to allow anyone to use private repos, see #5170. We could probably remove mayOpenPrivateRepo and some of the functions below. Cc @svenefftinge

* A user may open private repos if he either:
* - not started his free "priate repo trial" yet
* - is has been no longer than 30 days since he started his "priate repo trial"
* A user may open private repos if they either:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Much more inclusive!

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c725597e3ff1b70b278eb0d8b3db703556fcb56

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants