-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller-runtime and k8s go dependencies #5802
Conversation
/werft run 👍 started the job as gitpod-build-aledbf-cr10.1 |
/werft run 👍 started the job as gitpod-build-aledbf-cr10.2 |
@aledbf just to confirm, are you really expecting a review from everyone in @AlexTugarev, @corneliusludmann, @geropl, @svenefftinge and myself? (If not, please remove the unnecessary review requests 🙏) |
@jankeromnes No, the assignment was done by @roboquat |
Codecov Report
@@ Coverage Diff @@
## main #5802 +/- ##
==========================================
+ Coverage 32.96% 33.44% +0.48%
==========================================
Files 114 120 +6
Lines 21537 21912 +375
==========================================
+ Hits 7100 7329 +229
- Misses 13819 13928 +109
- Partials 618 655 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/werft run 👍 started the job as gitpod-build-aledbf-cr10.4 |
I see a lot of these messages:
Not sure this is related, but it cannot schedule ghost for whatever reason. Regular workspaces seem to work fine, though. 🤔 |
/approve no-issue |
/assign @csweichel |
After last rebase I don't see errors in ws-scheduler |
/werft run 👍 started the job as gitpod-build-aledbf-cr10.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx! 🙏
LGTM label has been added. Git tree hash: 1b50f4a358d5c8f74ac1e2db3c6a549a4282cd44
|
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, aledbf, csweichel, geropl Associated issue requirement bypassed by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release Notes