Update controller-runtime and k8s go dependencies #5802

aledbf · 2021-09-22T00:01:41Z

Release Notes

Update Kubernetes dependencies to v0.22.2
Update controller-runtime to v0.10.1

aledbf · 2021-09-22T00:28:27Z

/werft run

👍 started the job as gitpod-build-aledbf-cr10.1

aledbf · 2021-09-22T00:43:47Z

/werft run

👍 started the job as gitpod-build-aledbf-cr10.2

jankeromnes · 2021-09-23T15:12:28Z

@aledbf just to confirm, are you really expecting a review from everyone in @AlexTugarev, @corneliusludmann, @geropl, @svenefftinge and myself? (If not, please remove the unnecessary review requests 🙏)

aledbf · 2021-09-23T15:15:08Z

@jankeromnes No, the assignment was done by @roboquat

codecov · 2021-09-30T11:54:59Z

Codecov Report

Merging #5802 (ee09c3d) into main (64cb84b) will increase coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5802      +/-   ##
==========================================
+ Coverage   32.96%   33.44%   +0.48%     
==========================================
  Files         114      120       +6     
  Lines       21537    21912     +375     
==========================================
+ Hits         7100     7329     +229     
- Misses      13819    13928     +109     
- Partials      618      655      +37

Flag	Coverage Δ
components-blobserve-app	`29.49% <ø> (ø)`
components-blobserve-lib	`29.31% <ø> (-0.19%)`	⬇️
components-content-service-api-go-lib	`∅ <ø> (∅)`
components-content-service-app	`14.48% <ø> (ø)`
components-content-service-lib	`14.48% <ø> (ø)`
components-ee-agent-smith-app	`25.52% <ø> (ø)`
components-ee-agent-smith-lib	`25.52% <ø> (ø)`
components-ee-kedge-app	`45.48% <ø> (ø)`
components-ee-ws-scheduler-app	`62.99% <ø> (ø)`
components-ee-ws-scheduler-lib	`62.99% <ø> (ø)`
components-image-builder-api-go-lib	`∅ <ø> (∅)`
components-image-builder-app	`34.44% <ø> (ø)`
components-image-builder-bob-app	`∅ <ø> (∅)`
components-image-builder-mk3-app	`34.46% <ø> (ø)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`
components-openvsx-proxy-app	`46.22% <ø> (?)`
components-registry-facade-app	`11.63% <ø> (ø)`
components-registry-facade-lib	`11.63% <ø> (ø)`
components-service-waiter-app	`∅ <ø> (∅)`
components-supervisor-app	`37.83% <ø> (+0.24%)`	⬆️
components-workspacekit-app	`7.09% <ø> (ø)`
components-ws-daemon-api-go-lib	`∅ <ø> (∅)`
components-ws-daemon-app	`22.11% <ø> (ø)`
components-ws-daemon-lib	`22.11% <ø> (ø)`
components-ws-daemon-nsinsider-app	`∅ <ø> (∅)`
components-ws-manager-api-go-lib	`∅ <ø> (∅)`
components-ws-manager-app	`39.26% <ø> (ø)`
components-ws-proxy-app	`68.89% <ø> (-0.16%)`	⬇️
components-ws-proxy-lib	`69.04% <ø> (ø)`
dev-loadgen-app	`∅ <ø> (∅)`
installer-app	`6.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/openvsx-proxy/pkg/modifyresponse.go	`72.52% <0.00%> (ø)`
components/openvsx-proxy/pkg/utils.go	`47.36% <0.00%> (ø)`
components/openvsx-proxy/pkg/run.go	`14.06% <0.00%> (ø)`
components/openvsx-proxy/pkg/cache.go	`45.45% <0.00%> (ø)`
components/openvsx-proxy/pkg/handler.go	`47.47% <0.00%> (ø)`
components/openvsx-proxy/pkg/prometheus.go	`74.33% <0.00%> (ø)`
components/openvsx-proxy/pkg/errorhandler.go	`0.00% <0.00%> (ø)`
components/openvsx-proxy/pkg/config.go	`6.06% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64cb84b...ee09c3d. Read the comment docs.

geropl · 2021-10-05T08:12:12Z

/werft run

👍 started the job as gitpod-build-aledbf-cr10.4

geropl · 2021-10-05T08:28:23Z

I see a lot of these messages:

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"zero nodes available:\n    github.com/gitpod-io/gitpod/ws-scheduler/pkg/scheduler.(*Scheduler).selectNodeForPod\n        github.com/gitpod-io/gitpod/ws-scheduler/pkg/scheduler/scheduler.go:468","fields.message":"no suitable node found: zero nodes available","level":"warning","message":"scheduling a pod failed: Unschedulable","pod":"ghost-1d651031-6d68-41c7-8ff0-b451e90f2a20","reason":"Unschedulable","serviceContext":{"service":"ws-scheduler","version":""},"severity":"WARNING","time":"2021-10-05T08:16:36Z"}

Not sure this is related, but it cannot schedule ghost for whatever reason.

Regular workspaces seem to work fine, though. 🤔

aledbf · 2021-10-11T23:15:49Z

/approve no-issue

aledbf · 2021-10-11T23:16:07Z

/assign @csweichel

aledbf · 2021-10-11T23:29:00Z

I see a lot of these messages:

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"zero nodes available:\n    github.com/gitpod-io/gitpod/ws-scheduler/pkg/scheduler.(*Scheduler).selectNodeForPod\n        github.com/gitpod-io/gitpod/ws-scheduler/pkg/scheduler/scheduler.go:468","fields.message":"no suitable node found: zero nodes available","level":"warning","message":"scheduling a pod failed: Unschedulable","pod":"ghost-1d651031-6d68-41c7-8ff0-b451e90f2a20","reason":"Unschedulable","serviceContext":{"service":"ws-scheduler","version":""},"severity":"WARNING","time":"2021-10-05T08:16:36Z"}

Not sure this is related, but it cannot schedule ghost for whatever reason.

Regular workspaces seem to work fine, though. thinking

After last rebase I don't see errors in ws-scheduler

geropl · 2021-10-14T13:28:07Z

/werft run

👍 started the job as gitpod-build-aledbf-cr10.8

geropl

LGTM

Thx! 🙏

roboquat · 2021-10-14T13:47:31Z

LGTM label has been added.

Git tree hash: 1b50f4a358d5c8f74ac1e2db3c6a549a4282cd44

csweichel · 2021-10-14T13:55:48Z

/approve

akosyakov · 2021-10-14T15:13:11Z

/approve

roboquat · 2021-10-14T15:13:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, aledbf, csweichel, geropl

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [akosyakov,aledbf,csweichel,geropl]
~~components/blobserve/OWNERS~~ [aledbf,csweichel]
~~components/common-go/OWNERS~~ [aledbf,csweichel]
~~components/content-service/OWNERS~~ [aledbf,csweichel]
~~components/content-service-api/OWNERS~~ [csweichel,geropl]
~~components/ee/agent-smith/OWNERS~~ [aledbf,csweichel]
~~components/ee/kedge/OWNERS~~ [geropl]
~~components/ee/ws-scheduler/OWNERS~~ [aledbf,csweichel]
~~components/image-builder/OWNERS~~ [aledbf,csweichel]
~~components/image-builder-api/OWNERS~~ [csweichel,geropl]
~~components/openvsx-proxy/OWNERS~~ [akosyakov]
~~components/registry-facade/OWNERS~~ [aledbf,csweichel]
~~components/service-waiter/OWNERS~~ [geropl]
~~components/supervisor/OWNERS~~ [akosyakov]
~~components/workspacekit/OWNERS~~ [aledbf,csweichel]
~~components/ws-daemon/OWNERS~~ [aledbf,csweichel]
~~components/ws-daemon-api/OWNERS~~ [aledbf,csweichel]
~~components/ws-manager/OWNERS~~ [aledbf,csweichel]
~~components/ws-manager-api/OWNERS~~ [aledbf,csweichel]
~~components/ws-manager-bridge-api/OWNERS~~ [csweichel,geropl]
~~components/ws-proxy/OWNERS~~ [aledbf,csweichel]
~~dev/gpctl/OWNERS~~ [aledbf,csweichel]
~~dev/loadgen/OWNERS~~ [aledbf,csweichel]
~~installer/OWNERS~~ [aledbf,csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roboquat added the release-note label Sep 22, 2021

roboquat requested review from AlexTugarev, corneliusludmann, geropl, jankeromnes and svenefftinge September 22, 2021 00:01

roboquat added the size/XXL label Sep 22, 2021

aledbf removed request for svenefftinge, jankeromnes, AlexTugarev and corneliusludmann September 23, 2021 15:14

aledbf force-pushed the aledbf/cr10 branch from 3b9eec4 to 4f84371 Compare September 30, 2021 11:38

aledbf force-pushed the aledbf/cr10 branch from 4f84371 to 4de808a Compare October 11, 2021 23:15

roboquat assigned csweichel Oct 11, 2021

aledbf force-pushed the aledbf/cr10 branch from 4de808a to baba799 Compare October 12, 2021 13:52

roboquat added team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Oct 12, 2021

Update controller-runtime and k8s go dependencies

ee09c3d

aledbf force-pushed the aledbf/cr10 branch from baba799 to ee09c3d Compare October 12, 2021 13:55

geropl approved these changes Oct 14, 2021

View reviewed changes

roboquat assigned geropl Oct 14, 2021

roboquat added the lgtm label Oct 14, 2021

roboquat added the approved label Oct 14, 2021

roboquat merged commit 1854bfa into main Oct 14, 2021

roboquat deleted the aledbf/cr10 branch October 14, 2021 15:14

roboquat added deployed: workspace Workspace team change is running in production deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update controller-runtime and k8s go dependencies #5802

Update controller-runtime and k8s go dependencies #5802

aledbf commented Sep 22, 2021 •

edited

Loading

aledbf commented Sep 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Sep 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 23, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Sep 23, 2021

codecov bot commented Sep 30, 2021 •

edited

Loading

geropl commented Oct 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Oct 5, 2021

aledbf commented Oct 11, 2021

aledbf commented Oct 11, 2021

aledbf commented Oct 11, 2021

geropl commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading

geropl left a comment

roboquat commented Oct 14, 2021

csweichel commented Oct 14, 2021

akosyakov commented Oct 14, 2021

roboquat commented Oct 14, 2021

Update controller-runtime and k8s go dependencies #5802

Update controller-runtime and k8s go dependencies #5802

Conversation

aledbf commented Sep 22, 2021 • edited Loading

Release Notes

aledbf commented Sep 22, 2021 • edited by werft-gitpod-dev-com bot Loading

aledbf commented Sep 22, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Sep 23, 2021 • edited by werft-gitpod-dev-com bot Loading

aledbf commented Sep 23, 2021

codecov bot commented Sep 30, 2021 • edited Loading

Codecov Report

geropl commented Oct 5, 2021 • edited by werft-gitpod-dev-com bot Loading

geropl commented Oct 5, 2021

aledbf commented Oct 11, 2021

aledbf commented Oct 11, 2021

aledbf commented Oct 11, 2021

geropl commented Oct 14, 2021 • edited by werft-gitpod-dev-com bot Loading

geropl left a comment

Choose a reason for hiding this comment

roboquat commented Oct 14, 2021

csweichel commented Oct 14, 2021

akosyakov commented Oct 14, 2021

roboquat commented Oct 14, 2021

aledbf commented Sep 22, 2021 •

edited

Loading

aledbf commented Sep 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

aledbf commented Sep 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Sep 23, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Sep 30, 2021 •

edited

Loading

geropl commented Oct 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Oct 14, 2021 •

edited by werft-gitpod-dev-com bot

Loading