Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kube-rbac-proxy configuration for ws-manager-bridge and proxy #5818

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 22, 2021

Description

The ClusterRoleBinding is required for access to TokenReviews

Release Notes

[ws-manager-bridge] Add missing cluster role binding for tokenreviews
[proxy] Enable kube-rbac-proxy

@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2021

/werft run

👍 started the job as gitpod-build-aledbf-missingcrb.1

@roboquat roboquat added size/M and removed size/S labels Sep 22, 2021
@aledbf aledbf changed the title [ws-manager-bridge] Add missing cluster role binding for tokenreviews Fix kube-rbac-proxy configuration for ws-manager-bridge and proxy Sep 22, 2021
@csweichel
Copy link
Contributor

csweichel commented Sep 23, 2021

/werft run no-preview

👍 started the job as gitpod-build-aledbf-missingcrb.4

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a95278a87002a33f6b3246557469f7941a4e78c

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d54282c into main Sep 23, 2021
@roboquat roboquat deleted the aledbf/missingcrb branch September 23, 2021 07:24
@@ -20,4 +20,29 @@ roleRef:
kind: ClusterRole
name: {{ .Release.Namespace }}-ns-psp:unprivileged
apiGroup: rbac.authorization.k8s.io
roleRef:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication roleRef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants