[db] Add index 'ind_dbsync' on d_b_code_sync_resource

[geropl]

Description

Adds missing index ind_dbsync to table d_b_code_sync_resource.

Related Issue(s)

Fixes #6004

How to test

Release Notes

[db] add missing index `ind_dbsync` to table `d_b_code_sync_resource`

[AlexTugarev]

/werft run

👍 started the job as gitpod-build-gpl-6004-sync-indexes.2

[jankeromnes]

Thanks! Looks good to me 🚀 also works as intended:

mysql> show index from d_b_code_sync_resource;
+------------------------+------------+------------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table                  | Non_unique | Key_name   | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+------------------------+------------+------------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| d_b_code_sync_resource |          0 | PRIMARY    |            1 | userId      | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
| d_b_code_sync_resource |          0 | PRIMARY    |            2 | kind        | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
| d_b_code_sync_resource |          0 | PRIMARY    |            3 | rev         | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
| d_b_code_sync_resource |          1 | ind_dbsync |            1 | created     | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
+------------------------+------------+------------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
4 rows in set (0.00 sec)

Although, now I wonder what this decorator does (if anything):

gitpod/components/gitpod-db/src/typeorm/entity/db-code-sync-resource.ts

Line 34 in d114f03

@Index('ind_dbsync', ['created']) // DBSync

[jankeromnes]

Do we really want to remove the index again if rolling back? (I think we could also leave it in place without consequence.)

[jankeromnes]

FYI, today I learned about this helper (which doesn't seem to be used anywhere):

gitpod/components/gitpod-db/src/typeorm/migration/helper/helper.ts

Lines 9 to 18 in af51739

	export async function createIndexIfNotExist(queryRunner: QueryRunner, tableName: string, indexName: string, columns: string[]): Promise<void> {
	if (columns.length === 0) {
	throw new Error("createIndexIfNotExist: Columns must not be empty!");
	}
	if (!indexExists(queryRunner, tableName, indexName)) {
	const columnsStr = columns.map(cn => `\`${cn}\``).join(", ");
	await queryRunner.query(`CREATE INDEX ${indexName} ON ${tableName} (${columnsStr})`);
	}
	};

However, no action needed here (feel free to resolve).

[roboquat]

LGTM label has been added.

Git tree hash: dadabee06cd4abd4bb603b489a10fdfab71d1998

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #6004

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/gitpod-db/OWNERS [jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment