Replace /workspaces → /projects as default landing page for both users and teams #6048

jankeromnes · 2021-10-05T11:22:59Z

Description

Related Issue(s)

How to test

Visiting the dashboard should open the Projects page by default
Switching to a team should open the Projects page by default

Release Notes

Replace /workspaces → /projects as default landing page for both users and teams

jankeromnes · 2021-10-05T11:23:17Z

/approve

gtsiolis · 2021-10-05T11:32:00Z

Looking at this ...when the build is finished! 👀

jankeromnes · 2021-10-05T11:40:33Z

Thanks @gtsiolis!

I feel like the Projects page is missing some New Workspace buttons (or at least context menu option) to make it a great default landing page.

Currently, with this PR, the "shortest path to a workspace" is:

Load Projects page
Open Branches overview (and wait for half an eternity)
Click on New Workspace

jankeromnes · 2021-10-05T13:43:21Z

See also: #6047 (comment) (possibly related to this change)

jankeromnes · 2021-10-06T08:23:31Z

Added a drive-by change: A New Workspace context menu option for all Projects cards.

EDIT: Spliced this commit out into its own PR: #6185

…s and teams

…ts cards

jankeromnes · 2021-10-11T13:31:48Z

Still waiting for a review! 😊 🙏

/werft run

👍 started the job as gitpod-build-jx-projects-default-page.5

laushinka · 2021-10-11T14:20:12Z

Thanks for this PR!
/lgtm

roboquat · 2021-10-11T14:20:20Z

LGTM label has been added.

Git tree hash: d3412d2917956887e600fa9e04d78dfb26f6a610

gtsiolis

I had a draft review that I never submitted here. 😭

Thanks for the reminder, @jankeromnes! ⏰

thought(non-blocking): Overall, looks great and into the right direction. However, posting here for visibility that this change would change the existing onboarding flow and could slightly affect usage.

Approving to unblock merging but holding while @laushinka also looks at this[1]. 👀

/hold

gtsiolis · 2021-10-05T11:40:44Z

.werft/build.ts

@@ -395,7 +395,7 @@ export async function deployToDev(deploymentConfig: DeploymentConfig, workspaceF
        werft.fail('deploy', err);
    } finally {
        // produce the result independently of Helm succeding, so that in case Helm fails we still have the URL.
-        exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/workspaces/`);
+        exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/projects`);


praise: Nice one! 💯

gtsiolis · 2021-10-05T11:41:08Z

.werft/build.ts

@@ -395,7 +395,7 @@ export async function deployToDev(deploymentConfig: DeploymentConfig, workspaceF
        werft.fail('deploy', err);
    } finally {
        // produce the result independently of Helm succeding, so that in case Helm fails we still have the URL.
-        exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/workspaces/`);
+        exec(`werft log result -d "dev installation" -c github-check-preview-env url ${url}/projects`);


question: Probably going with / this could also work, right?

gtsiolis · 2021-10-11T14:14:07Z

components/dashboard/src/projects/Projects.tsx

-                                            customFontStyle: 'text-red-600 dark:text-red-400 hover:text-red-800 dark:hover:text-red-300',
-                                            onClick: () => onRemoveProject(p)
-                                        }]} />
+                                        <ContextMenu menuEntries={[


issue: This is out of the scope of these changes but do you think it'd be easy to add a hover state on the more action button as seen everywhere else?

Adding hover:bg-gray-200 dark:hover:bg-gray-700 rounded-md in the Context Menu component could suffice unless I'm missing something. What do you think? Feel free to open a follow up PR if needed.

gitpod/components/dashboard/src/components/ContextMenu.tsx

Line 72 in 5503c9b

const children = props.children || <svg className="w-8 h-8 p-1 text-gray-600 dark:text-gray-300" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><title>Actions</title><g fill="currentColor" transform="rotate(90 12 12)"><circle cx="1" cy="1" r="2" transform="translate(5 11)" /><circle cx="1" cy="1" r="2" transform="translate(11 11)" /><circle cx="1" cy="1" r="2" transform="translate(17 11)" /></g></svg>;

Good catch! Pushed a new drive-by commit to fix this. 🚀

EDIT: In #6185, that is.

gtsiolis · 2021-10-11T14:17:54Z

components/dashboard/src/projects/Projects.tsx

-                                        }]} />
+                                        <ContextMenu menuEntries={[
+                                            {
+                                                title: "New Workspace",


praise: YES!

roboquat · 2021-10-11T14:20:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes, laushinka

Associated issue: #5050

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gtsiolis,jankeromnes,laushinka]
~~components/dashboard/OWNERS~~ [gtsiolis,jankeromnes,laushinka]
~~components/gitpod-protocol/OWNERS~~ [gtsiolis,jankeromnes,laushinka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

laushinka · 2021-10-11T15:18:38Z

If I've added an lgtm, do I also have to add an approve tag?

jankeromnes · 2021-10-11T18:14:32Z

If I've added an lgtm, do I also have to add an approve tag?

@laushinka no need 🙂 you can see in @roboquat's comment above that your "lgtm" also counted as an "approve":

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes, laushinka

If you're wondering why this PR isn't merged, that's because of the "do-not-merge/hold" label.

Before we remove that and merge this PR, I think we need more buy-in for the new default location, especially from product.

Relatedly, what do you think of this @jldec?

jldec · 2021-10-12T01:02:33Z

If this will make the "new project" onboarding flow the default first experience for new users, I would recommend holding this for now.

I think the new project flow is still a bit long and can be difficult to understand in places, especially for noobs like myself. See screenshots (internal only)

stale · 2021-10-23T19:44:55Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jldec · 2021-10-25T09:13:34Z

I think we should move forward with this.

/unhold

roboquat added the release-note-none label Oct 5, 2021

roboquat requested review from aledbf, gtsiolis and laushinka October 5, 2021 11:23

roboquat added the size/S label Oct 5, 2021

roboquat added the approved label Oct 5, 2021

jankeromnes requested a review from AlexTugarev October 5, 2021 11:25

gtsiolis added component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience labels Oct 5, 2021

gtsiolis mentioned this pull request Oct 5, 2021

Roboquat does not move issues to review column in groundwork even if labels are applied correctly gitpod-io/gitbot#33

Closed

jankeromnes force-pushed the jx/projects-default-page branch from b08beed to c653f05 Compare October 6, 2021 08:20

roboquat added size/M and removed size/S labels Oct 6, 2021

jankeromnes force-pushed the jx/projects-default-page branch 2 times, most recently from 36ff5e3 to f74bb72 Compare October 6, 2021 09:28

jankeromnes removed the request for review from aledbf October 7, 2021 17:14

jankeromnes added 2 commits October 8, 2021 07:06

Replace /workspaces → /projects as default landing page for both user…

1bf72e1

…s and teams

[projects] Add 'New Workspace' context menu option to all Team Projec…

55c8f6b

…ts cards

jankeromnes force-pushed the jx/projects-default-page branch from f74bb72 to 55c8f6b Compare October 8, 2021 07:06

roboquat added release-note and removed release-note-none labels Oct 8, 2021

roboquat assigned laushinka Oct 11, 2021

roboquat added the lgtm label Oct 11, 2021

gtsiolis approved these changes Oct 11, 2021

View reviewed changes

roboquat added the do-not-merge/hold label Oct 11, 2021

roboquat assigned gtsiolis Oct 11, 2021

jldec mentioned this pull request Oct 12, 2021

New Project flow fails detection on private repos if oauth is fresh #6168

Closed

jankeromnes mentioned this pull request Oct 13, 2021

[projects] Add 'New Workspace' context menu option to all Projects cards #6185

Merged

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 23, 2021

jldec added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Oct 25, 2021

roboquat removed the do-not-merge/hold label Oct 25, 2021

roboquat merged commit 8e9f612 into main Oct 25, 2021

roboquat deleted the jx/projects-default-page branch October 25, 2021 09:14

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 31, 2021

gtsiolis mentioned this pull request Nov 5, 2021

Preserve team scope in dashboard #6577

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace /workspaces → /projects as default landing page for both users and teams #6048

Replace /workspaces → /projects as default landing page for both users and teams #6048

jankeromnes commented Oct 5, 2021 •

edited

Loading

jankeromnes commented Oct 5, 2021

gtsiolis commented Oct 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 5, 2021 •

edited

Loading

jankeromnes commented Oct 5, 2021

jankeromnes commented Oct 6, 2021 •

edited

Loading

jankeromnes commented Oct 11, 2021 •

edited by werft-gitpod-dev-com bot

Loading

laushinka commented Oct 11, 2021

roboquat commented Oct 11, 2021

gtsiolis left a comment

gtsiolis Oct 5, 2021

gtsiolis Oct 5, 2021

gtsiolis Oct 11, 2021

jankeromnes Oct 13, 2021 •

edited

Loading

gtsiolis Oct 11, 2021

roboquat commented Oct 11, 2021

laushinka commented Oct 11, 2021

jankeromnes commented Oct 11, 2021 •

edited

Loading

jldec commented Oct 12, 2021

stale bot commented Oct 23, 2021

jldec commented Oct 25, 2021

Replace /workspaces → /projects as default landing page for both users and teams #6048

Replace /workspaces → /projects as default landing page for both users and teams #6048

Conversation

jankeromnes commented Oct 5, 2021 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

jankeromnes commented Oct 5, 2021

gtsiolis commented Oct 5, 2021 • edited by werft-gitpod-dev-com bot Loading

jankeromnes commented Oct 5, 2021 • edited Loading

jankeromnes commented Oct 5, 2021

jankeromnes commented Oct 6, 2021 • edited Loading

jankeromnes commented Oct 11, 2021 • edited by werft-gitpod-dev-com bot Loading

laushinka commented Oct 11, 2021

roboquat commented Oct 11, 2021

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Oct 5, 2021

Choose a reason for hiding this comment

gtsiolis Oct 5, 2021

Choose a reason for hiding this comment

gtsiolis Oct 11, 2021

Choose a reason for hiding this comment

jankeromnes Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

gtsiolis Oct 11, 2021

Choose a reason for hiding this comment

roboquat commented Oct 11, 2021

laushinka commented Oct 11, 2021

jankeromnes commented Oct 11, 2021 • edited Loading

jldec commented Oct 12, 2021

stale bot commented Oct 23, 2021

jldec commented Oct 25, 2021

jankeromnes commented Oct 5, 2021 •

edited

Loading

gtsiolis commented Oct 5, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 5, 2021 •

edited

Loading

jankeromnes commented Oct 6, 2021 •

edited

Loading

jankeromnes commented Oct 11, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes Oct 13, 2021 •

edited

Loading

jankeromnes commented Oct 11, 2021 •

edited

Loading