Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]: additional bugfixes #6448

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Oct 29, 2021

Description

More bugfixes on the installation. These are mostly due to finding errors with image building

  • add configmap to ws-scheduler
  • add MarshalJSON function to TimeOfDay to reverse the UnmarshalJSON
  • handle error if IdeImage not sent to ws-manager
  • more bugfixes

This is still not a complete deployment to GKE InCluster, but exists so as to share the workload

Related Issue(s)

Fixes #

How to test

Release Notes

More bugfixes on the installation

 - add configmap to `ws-scheduler`
 - add `MarshalJSON` function to `TimeOfDay` to reverse the `UnmarshalJSON`
 - handle error if `IdeImage` not sent to ws-manager

Documentation

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #6448 (25f21ac) into main (8884ea2) will decrease coverage by 14.32%.
The diff coverage is 0.00%.

❗ Current head 25f21ac differs from pull request most recent head f2387ec. Consider uploading reports for the commit f2387ec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6448       +/-   ##
==========================================
- Coverage   21.47%   7.15%   -14.33%     
==========================================
  Files          20      10       -10     
  Lines        1644     923      -721     
==========================================
- Hits          353      66      -287     
+ Misses       1247     855      -392     
+ Partials       44       2       -42     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-openvsx-proxy-lib ?
installer-app 7.15% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/common.go 1.26% <0.00%> (-0.01%) ⬇️
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 14.08% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.05% <0.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/openvsx-proxy/pkg/prometheus.go
components/openvsx-proxy/pkg/utils.go
components/openvsx-proxy/pkg/cache.go
components/local-app/pkg/auth/auth.go
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8884ea2...f2387ec. Read the comment docs.

@mrsimonemms mrsimonemms force-pushed the sje/installer-workspace-fixes-gke branch from f830248 to 63dc1b1 Compare October 29, 2021 08:05
@mrsimonemms mrsimonemms changed the title Sje/installer workspace fixes gke [Installer]: additional bugfixes Oct 29, 2021
@mrsimonemms mrsimonemms force-pushed the sje/installer-workspace-fixes-gke branch 14 times, most recently from 25f21ac to 14cbf07 Compare November 2, 2021 11:01
@mrsimonemms mrsimonemms marked this pull request as ready for review November 2, 2021 12:05
Simon Emms added 4 commits November 2, 2021 12:06
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

LGTM label has been added.

Git tree hash: 3baa91d2befba2deef68d60504edaf180dbef6ce

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit ab20361 into main Nov 2, 2021
@roboquat roboquat deleted the sje/installer-workspace-fixes-gke branch November 2, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants