Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] show error message on new project for Bitbucket-only users #6652

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

JanKoehnlein
Copy link
Contributor

Description

Show a message that Bitbucket is not yet supported instead of silently failing for Bitbucket-only users on New Project page.

Related Issue(s)

Fixes #6345

How to test

  • Log in with a Bitbucket only account
  • Open to /new

Release Notes

Bitbucket-only users get an error message now on _New Project_ page

Documentation

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Nov 15, 2021

/werft run

👍 started the job as gitpod-build-jk-bitbucket-message.2

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 17, 2021

Re-deploying as Bitbucket is now enabled on preview environments, see relevant discussion (internal).

/werft run

👍 started the job as gitpod-build-jk-bitbucket-message.3

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this an early look! 👀

@JanKoehnlein What do you think of using the same flow, existing components, and an alert for providing this feedback to the user instead of leading users to this error page?

BEFORE CURRENT PROPOSAL
Screenshot 2021-11-17 at 7 22 25 PM (2) Screenshot 2021-11-17 at 7 30 45 PM (2) Screenshot 2021-11-17 at 7 28 03 PM (2)

Cc @jldec since you've added the error page proposal #6345. 📝

Cc @laushinka @geropl @jankeromnes @AlexTugarev in case you have any feebdack on this. 🔮

@JanKoehnlein
Copy link
Contributor Author

@gtsiolis absolutely. This PR is still draft mode because I did a very quick first shot at that and when I tried to look at it the preview env was broken. I can look at that between the meetings today.

@AlexTugarev
Copy link
Member

I think an entry is missing in

setAuthProviders(providers.filter(p => ["github.com", "gitlab.com"].includes(p.host)));

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM:

image

@AlexTugarev I think this is by design (see screenshot).

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #6345

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: e5f6cc0e787f664e106f1e6258c87bd5f04f047f

@geropl
Copy link
Member

geropl commented Nov 19, 2021

Whoops, should be a comment 😬 But IMO fine anyway. Can create a small follow-up PR if needed @AlexTugarev

@roboquat roboquat merged commit d8ee631 into main Nov 19, 2021
@roboquat roboquat deleted the jk/bitbucket-message branch November 19, 2021 09:34
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Project page should show message and link to /workspaces when authorized only with Bitbucket
5 participants