Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Allow all team members to cancel a team prebuild #6713

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Nov 15, 2021

Description

Allow all team members to cancel a team prebuild.

Drive-by: Fix Cancel Prebuild button state in Prebuild page.

Related Issue(s)

Fixes #6549

How to test

  1. Have a team with at least two users: let's call them user A and user B
  2. Start a prebuild as user A
  3. Try to cancel the prebuild as user B

The cancellation should work, instead of logging an access error.

Release Notes

Allow all team members to cancel a team prebuild

Documentation

/uncc

@jankeromnes jankeromnes force-pushed the jx/cancel-team-prebuilds branch 2 times, most recently from 92a43b0 to 94c9bd7 Compare November 16, 2021 13:58
@roboquat roboquat added size/M and removed size/S labels Nov 16, 2021
@jankeromnes jankeromnes marked this pull request as ready for review November 16, 2021 14:23
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 16, 2021

Seems to work from my end 😊 please take a look when you have time! 🧡

@jankeromnes jankeromnes reopened this Nov 16, 2021
@jankeromnes
Copy link
Contributor Author

(wrong button)

@geropl
Copy link
Member

geropl commented Nov 16, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: eef32fa1b1d8995d2f53549795de34e07d348f01

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #6549

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit c52f8a0 into main Nov 16, 2021
@roboquat roboquat deleted the jx/cancel-team-prebuilds branch November 16, 2021 15:45
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Nov 19, 2021
@roboquat roboquat added the deployed Change is completely running in production label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Prebuild error: operation not permitted! missing get permission on workspace
3 participants