Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: change default containerd runtime dir #6920

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

mrsimonemms
Copy link
Contributor

Description

Use Azure/AWS/GCP rather than K3s default

How to test

Release Notes

Change installer default containerd runtime directory

Documentation

Use Azure/AWS/GCP rather than K3s default
@roboquat roboquat added the team: workspace Issue belongs to the Workspace team label Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #6920 (3e4f1db) into main (91dcd03) will decrease coverage by 13.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #6920       +/-   ##
==========================================
- Coverage   19.04%   5.83%   -13.22%     
==========================================
  Files           2      13       +11     
  Lines         168    1148      +980     
==========================================
+ Hits           32      67       +35     
- Misses        134    1080      +946     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
installer/pkg/common/common.go 4.74% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b6154...3e4f1db. Read the comment docs.

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d8fae05c784f0abc32565e4f9ed351fc7d707076

Copy link
Contributor

@princerachit princerachit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
it would help if we had links to pages in PR description where it says /var/lib/containerd/ is the default path for Azure/Aws etc

@mrsimonemms
Copy link
Contributor Author

LGTM it would help if we had links to pages in PR description where it says /var/lib/containerd/ is the default path for Azure/Aws etc

This is included as part of #6767

@csweichel
Copy link
Contributor

I think the main motivation for this change is not only AWS/Azure/GCP, but that the default root dir of containerd is /var/lib/containerd:
https://github.com/containerd/containerd/blob/6fa958853197af31ffd1225a6c300589e5068667/defaults/defaults_unix.go#L25

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, iQQBot, princerachit

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 1e6c5d7 into main Dec 1, 2021
@roboquat roboquat deleted the sje/installer-containerd-path branch December 1, 2021 07:15
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants