Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Improve team selection UX in new Project flow #7030

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jankeromnes
Copy link
Contributor

Description

Improves the team selection UX in new Project flow

Related Issue(s)

Fixes #6686

How to test

  1. https://jx-improve-team-select.staging.gitpod-dev.com/new
  2. Select any repository

Release Notes

[dashboard] Improve team selection UX in new Project flow

Documentation

/uncc

@jankeromnes
Copy link
Contributor Author

Work in progress:

Screenshot 2021-12-02 at 14 37 38 Screenshot 2021-12-02 at 14 38 25

@jankeromnes
Copy link
Contributor Author

New work in progress:

Screenshot 2021-12-02 at 19 41 51 Screenshot 2021-12-02 at 19 52 56
Screenshot 2021-12-02 at 19 42 28 Screenshot 2021-12-02 at 19 52 22

@jankeromnes jankeromnes marked this pull request as ready for review December 3, 2021 08:28
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 3, 2021

Okay, I think is good enough for now. It's not 100% aligned with the spec, but should give a pretty good idea of what option A feels like (and I almost feel like shipping this as is 🚢).

@gtsiolis @jldec please take a look when you have time. 🙏

@jldec
Copy link
Contributor

jldec commented Dec 6, 2021

I think there is still some test-team UI left over in the code
I created a team called test-team and it shows 23 members (only in the team-select page) just like your yolo team
Screenshot 2021-12-06 at 00 06 55

@jldec
Copy link
Contributor

jldec commented Dec 6, 2021

General feedback: I think this is much easier to use - definitely a huge improvement.

I'm still a bit unsure about the auto-select personal account for any new project started from the dashboard when you're not under a team. I think users will not intuitively know when they're in a personal account context (and creating projects there). Going to /new isn't easy to do manually unless you're in the know.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 6, 2021

I think there is still some test-team UI left over in the code
I created a team called test-team and it shows 23 members (only in the team-select page) just like your yolo team

Oh no 🙈 good catch! I'll fix that.

I'm still a bit unsure about the auto-select personal account for any new project started from the dashboard when you're not under a team. I think users will not intuitively know when they're in a personal account context (and creating projects there). Going to /new isn't easy to do manually unless you're in the know.

Hmm, I agree. It's orthogonal to this PR, but seems to be worth a follow-up issue. For what it's worth, I think we have these possible fixes:

a. Re-instate team selection when you create a new project from your personal account context (i.e. revert #6966)
b. Make it easy to move a project from a personal account to a team
c. Implement some UI shortcuts e.g. to "Share access to this project with collaborators" (which could do "create a new team" and "move personal project to that new team" behind the scenes)

... or a combination of a/b/c.

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 6, 2021

I think there is still some test-team UI left over in the code
I created a team called test-team and it shows 23 members (only in the team-select page) just like your yolo team

Fixed ✅

Ready to be merged if UX works well 👍

Please approve @jldec / @gtsiolis

@jldec
Copy link
Contributor

jldec commented Dec 6, 2021

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

LGTM label has been added.

Git tree hash: 9254053cb99d81a3a29a4ec13eb237eced479fb4

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #6686

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 35b8283 into main Dec 6, 2021
@roboquat roboquat deleted the jx/improve-team-select branch December 6, 2021 22:32
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Dec 7, 2021
@roboquat roboquat added the deployed Change is completely running in production label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update team selection design for onboarding flow
3 participants