Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable experimentalNetwork by default #7063

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Enable experimentalNetwork by default #7063

merged 1 commit into from
Dec 7, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 4, 2021

Description

Now that we use a more recent kernel we can enable this feature by default

Release Notes

Enable experimentalNetwork by default

Documentation

@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team labels Dec 4, 2021
@aledbf aledbf requested a review from csweichel December 4, 2021 12:13
@roboquat roboquat added team: workspace Issue belongs to the Workspace team size/M labels Dec 4, 2021
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #7063 (3e040d5) into main (302dc2b) will decrease coverage by 11.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7063       +/-   ##
==========================================
- Coverage   19.04%   7.19%   -11.86%     
==========================================
  Files           2       4        +2     
  Lines         168     723      +555     
==========================================
+ Hits           32      52       +20     
- Misses        134     668      +534     
- Partials        2       3        +1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-workspacekit-app 7.19% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 6.46% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)
components/workspacekit/cmd/nsenter.go 25.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302dc2b...3e040d5. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

LGTM label has been added.

Git tree hash: 1a033434e7a0327a409bc9fe66e552db7ffd3ce1

@csweichel
Copy link
Contributor

/approve no-issue

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

roboquat commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 537672b into main Dec 7, 2021
@roboquat roboquat deleted the aledbf/exp branch December 7, 2021 15:53
@shaal
Copy link
Contributor

shaal commented Dec 7, 2021

How can we know when this becomes the default in production?

@aledbf
Copy link
Member Author

aledbf commented Dec 7, 2021

@shaal the next deployment is scheduled before the end of the week. That said, we don't have a straightforward way to communicate when a change like this one is available. But we are working on it.

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 9, 2021
@aledbf
Copy link
Member Author

aledbf commented Dec 10, 2021

@shaal this change is available in production now. Check If the URL contains *.ws-*23.gitpod.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants