Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ide-proxy provide ide logo #7227

Merged
merged 1 commit into from
Jan 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chart/templates/proxy-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ data:

{{- if not .Values.components.ideProxy.disabled }}
vhost.ide: |
https://ide-proxy.{$GITPOD_DOMAIN} {
https://ide.{$GITPOD_DOMAIN} {
import enable_log_debug
import remove_server_header
import ssl_configuration

reverse_proxy {
to ide.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:{{.Values.components.ideProxy.ports.http.servicePort}}
to ide-proxy.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:{{.Values.components.ideProxy.ports.http.servicePort}}
}
}
{{- end }}
Expand Down
16 changes: 8 additions & 8 deletions chart/templates/server-ide-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ options:
orderKey: "00"
title: "VS Code"
type: "browser"
logo: "vscode"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscode.svg"
image: {{ (include "stable-image-full" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.codeImage)) }}
code-latest:
orderKey: "01"
title: "VS Code"
type: "browser"
logo: "vscode-insiders"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscodeInsiders.svg"
tooltip: "Early access version, still subject to testing."
label: "Insiders"
image: {{ (include "insider-image-full" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.codeImage)) }}
Expand All @@ -63,42 +63,42 @@ options:
orderKey: "02"
title: "VS Code"
type: "desktop"
logo: "vscode"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscode.svg"
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.codeDesktop)) }}
code-desktop-insiders:
orderKey: "03"
title: "VS Code"
type: "desktop"
logo: "vscode-insiders"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscodeInsiders.svg"
tooltip: "Visual Studio Code Insiders for early adopters."
label: "Insiders"
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.codeDesktopInsiders)) }}
intellij:
orderKey: "04"
title: "IntelliJ IDEA"
type: "desktop"
logo: "intellij-idea"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/intellijIdeaLogo.svg"
notes: ["While in beta, when you open a workspace with IntelliJ IDEA you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.intellij)) }}
goland:
orderKey: "05"
title: "GoLand"
type: "desktop"
logo: "goland"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/golandLogo.svg"
notes: ["While in beta, when you open a workspace with GoLand you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.goland)) }}
pycharm:
orderKey: "06"
title: "PyCharm"
type: "desktop"
logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/pycharmLogo.svg"
notes: ["While in beta, when you open a workspace with PyCharm you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.pycharm)) }}
phpstorm:
orderKey: "07"
title: "PhpStorm"
type: "desktop"
logo: "https://upload.wikimedia.org/wikipedia/commons/c/c9/PhpStorm_Icon.svg"
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/phpstormLogo.svg"
notes: ["While in beta, when you open a workspace with PhpStorm you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.phpstorm)) }}

Expand Down
1 change: 0 additions & 1 deletion components/dashboard/src/images/golandLogo.svg

This file was deleted.

18 changes: 0 additions & 18 deletions components/dashboard/src/images/ideLogos.ts

This file was deleted.

1 change: 0 additions & 1 deletion components/dashboard/src/images/intellijIdeaLogo.svg

This file was deleted.

11 changes: 0 additions & 11 deletions components/dashboard/src/images/vscode.svg

This file was deleted.

37 changes: 0 additions & 37 deletions components/dashboard/src/images/vscodeInsiders.svg

This file was deleted.

3 changes: 1 addition & 2 deletions components/dashboard/src/settings/Preferences.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { PageWithSubMenu } from "../components/PageWithSubMenu";
import PillLabel from "../components/PillLabel";
import SelectableCard from "../components/SelectableCard";
import Tooltip from "../components/Tooltip";
import ideLogos from '../images/ideLogos';
import { getGitpodService } from "../service/service";
import { ThemeContext } from "../theme-context";
import { UserContext } from "../user-context";
Expand Down Expand Up @@ -215,7 +214,7 @@ function renderIdeOption(option: IDEOption, selected: boolean, onSelect: () => v
const card = <SelectableCard className="w-36 h-40" title={option.title} selected={selected} onClick={onSelect}>
<div className="flex justify-center mt-3">
<img className="w-16 filter-grayscale self-center"
src={option.logo.startsWith("http") ? option.logo : ideLogos[option.logo]} />
src={option.logo} alt="logo" />
</div>
{option.label ? <div className={`font-semibold text-sm ${selected ? 'text-green-500' : 'text-gray-500 dark:text-gray-400'} uppercase mt-2 ml-2 px-3 py-1 self-center`}>{option.label}</div> : <></>}
</SelectableCard>;
Expand Down
44 changes: 44 additions & 0 deletions components/ide-proxy/static/image/ide-logo/phpstormLogo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading