Link to user profile

[laushinka]

Description

Links the profile of the user who already added a project.
The profile provider should match the repo provider.

UPDATED

Related Issue(s)

Fixes #7310

How to test

1. Have two different accounts using the same Git provider.
2. Account A create a group/org and add projects/repos, and invite account B as member with write access.
3. Account A adds project to Gitpod.
4. Account B tries to add the project and should be shown the username of account A. This username should link to account A's profile on the Git provider website.

Release Notes

Profile of the user who already added a project is linked.

Documentation

[laushinka]

This is still a draft. @jldec Please help test using your usecase.

[laushinka]

/werft run

👍 started the job as gitpod-build-laushinka-link-username-7310.4

[laushinka]

/werft run

👍 started the job as gitpod-build-laushinka-link-username-7310.6

[laushinka]

Ready for that review and thumbs up! @jldec

[jldec]

@laushinka I think the code is not covering the specific case with 2 integrations each using a different user-id, which was mentioned in the issue:

Users with multiple integrations will be shown using the user-id of the first signup, which is not necessarily the user-id for the integration of the repo in question. E.g I used a different username for GitHub vs. GitLab and the "already added" message is showing my GitHub userid even though the repo is on GitLab.

To reproduce:

1. create an account with 2 integrations (first GitHub then GitLab) using different user-ids
2. create a project with a GitLab repo
3. try to create a 2nd project on the same GitLab repo

The message will say

@user already
added this repo

where @user is the GitHub user-id.
The link will go to a wrong (on non-existent) user on GitLab

The link should either go to the repo-owner's user-id (owner) on GitLab, or to the user-id on GitHub from integration 1.

[laushinka]

The link should either go to the repo-owner's user-id (owner) on GitLab, or to the user-id on GitHub from integration 1.

@jldec I managed to reproduce! Thanks for the steps and for catching it.

[laushinka]

@jldec Fixed the bug by checking that the owner provider matches the repo provider. Please test and confirm 🙏🏽

[laushinka]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-laushinka-link-username-7310.10

[jldec]

Thanks @laushinka - looks good.

[roboquat]

LGTM label has been added.

Git tree hash: 08afda6344f79eccaca4ed0305748a64f10a716e

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #7310

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS [jldec]
• components/server/OWNERS [jldec]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment