Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] set default branch for BitBucket provider #7371

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

trumbitta
Copy link
Contributor

@trumbitta trumbitta commented Dec 27, 2021

Description

I found mainbranch in the BitBucket API. Here's hoping it is our missing default branch.

I wasn't able to test it because I couldn't figure out how to rebuild the server app 😬 (whereas with Nx I would have known to run nx build server because the commands are always the same for every single project in the repo, no matter the language or framework - see #7334 😇🍊🦄)

Related Issue(s)

Fixes #7325
Fixes #7366

How to test

If anybody's willing to comment here and explain how to rebuild / relaunch the server project to test this, I'll be adding instructions to the README for future reference 🙏

Release Notes

[server] add default branch to BitBucket provider

@iQQBot
Copy link
Contributor

iQQBot commented Dec 27, 2021

/werft run

👍 started the job as gitpod-build-trumbitta-7325-fork.0

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @trumbitta! 🍊

UX works like a charm! 🔮

This will also resolve pinning the default branch on the top of the list, so feel free to include also #7366 in the PR description.

Approving to unblock merging but holding to ask for another pass for the code changes here from @AlexTugarev who recently changed this file in #7251. 🏀

/hold

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 707ab904451eacacddfe9a1866ce4c69ae1fe9d0

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #7325

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlexTugarev
Copy link
Member

AlexTugarev commented Jan 3, 2022

/werft run

👍 started the job as gitpod-build-trumbitta-7325-fork.1

@AlexTugarev
Copy link
Member

/hold cancel

Thanks @trumbitta and @gtsiolis! This is great!

@roboquat roboquat merged commit 34ed8e2 into gitpod-io:main Jan 3, 2022
@trumbitta trumbitta deleted the trumbitta/7325 branch January 3, 2022 11:05
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: accepted ✔️ community-contribution deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
5 participants