Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] improve startup performance #8158

Merged
merged 3 commits into from
Feb 13, 2022
Merged

[jetbrains] improve startup performance #8158

merged 3 commits into from
Feb 13, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 11, 2022

Description

Improve startup performance of JB backends by auto downloading shared indexes and preserving indexes between restarts.

It also reconfigured idea properties and vmoption. We should put them into /ide-desktop/backend/bin/idea.properties and idea64.vmoptions correspondingly. Otherwise JB will complain on each startup.

Related Issue(s)

Fixes #

How to test

  • Start a new workspace: https://ak-jb-index-enh.staging.gitpod-dev.com/#referrer:jetbrains-gateway/https://github.com/gitpod-io/spring-petclinic
  • You should not see any notifications about unnecessary JVM options or enabling shared indexes. You should see thought that shared indexes are auto downloading and maven modules are already importing, mvn deps are resolving, mvn plugins are downloading, etc. In production you will need to wait till JDK is indexed or enable shared indexes manually.
  • When maven background tasks are finished restart a workspace. This time tooling should be available almost immediately.

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #8158 (2667324) into main (07e013e) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8158      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e013e...2667324. Read the comment docs.

in order to suppress annoying user notificaiton on each thin client openning
@roboquat roboquat added size/M and removed size/S labels Feb 13, 2022
@akosyakov akosyakov marked this pull request as ready for review February 13, 2022 07:03
@akosyakov akosyakov requested a review from a team February 13, 2022 07:03
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested ✅
After restarted, the workspace is ready for use notable faster!

@roboquat roboquat merged commit 2bd00a2 into main Feb 13, 2022
@roboquat roboquat deleted the ak/jb_index_enh branch February 13, 2022 14:13
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants