-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed error propagation for on build context creation? #24
Comments
Unfortunately the link doesn't seem to include a line number. Where in the file is the issue? |
it's L268 and ☝️ it looks like the return is missing error case |
Indeed. There the error check is missing. I'll fix it later |
csweichel
pushed a commit
that referenced
this issue
Aug 5, 2020
csweichel
pushed a commit
that referenced
this issue
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This looks like a
is missing - alternatively a comment explaining why this is not the case.
@csweichel
The text was updated successfully, but these errors were encountered: