Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed error propagation for on build context creation? #24

Closed
geropl opened this issue Aug 5, 2020 · 4 comments · Fixed by #25
Closed

Missed error propagation for on build context creation? #24

geropl opened this issue Aug 5, 2020 · 4 comments · Fixed by #25

Comments

@geropl
Copy link
Member

geropl commented Aug 5, 2020

This looks like a

if err != nil {
  return err
}

is missing - alternatively a comment explaining why this is not the case.

@csweichel

@csweichel
Copy link
Collaborator

Unfortunately the link doesn't seem to include a line number. Where in the file is the issue?

@AlexTugarev
Copy link
Member

it's L268

https://github.com/TypeFox/leeway/blob/b80280bc23e54f066537c4d35b65d5fc8a10eedf/pkg/leeway/build.go#L268

and ☝️ it looks like the return is missing error case

@csweichel
Copy link
Collaborator

Indeed. There the error check is missing. I'll fix it later

@csweichel
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants