[layout] Make build-time filesystem layout explicit #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the build-time filesystem layout was created implicitly from the package names. This method breaks for nested workspaces where package names differ depending on their context. This makes built-time layout explicit by introducing a "layout" section in the package description. If no explicit layout is set, leeway will fall back to its prior behaviour and use the dependency's filesystem safe name. This mechanism is implemented during linking s.t. the build-time layout stays stable across nested workspaces. `leeway describe` has been updated accordingly to show the layout. `leeway vet` finds layout path clashes if two dependencies occupy the same path at build-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the build-time filesystem layout was created implicitly from the package names. This method breaks for nested workspaces where package names differ depending on their context.
This makes built-time layout explicit by introducing a "layout" section in the package description. If no explicit layout is set, leeway will fall back to its prior behaviour and use the dependency's filesystem safe name. This mechanism is implemented during linking s.t. the build-time layout stays stable across nested workspaces.
leeway describehas been updated accordingly to show the layout.leeway vetfinds layout path clashes if two dependencies occupy the same path at build-time.