Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localization): pull-list.screen.js copy/paste mistake #241

Merged
merged 2 commits into from
Aug 12, 2017
Merged

fix(localization): pull-list.screen.js copy/paste mistake #241

merged 2 commits into from
Aug 12, 2017

Conversation

tautf
Copy link
Contributor

@tautf tautf commented Aug 12, 2017

This PR fixes an Issue in the pull-list.screen.js

See below.

But this needs to be done than to every language file in the future.

Its probably just a copy/paste mistake.

Its my first PR so please give me any feedback you have! 😄

I will add myself to the contributors list with my next PR with german translation.

@tautf tautf changed the title pull-list.screen.js copy/paste mistake fix(localization): pull-list.screen.js copy/paste mistake Aug 12, 2017
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@lex111
Copy link
Member

lex111 commented Aug 12, 2017

You apparently do not work git hooks for you? We follow the git commit guidelines by Angular.

Copy link
Member

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, nice find

@andrewda andrewda merged commit 956cf65 into gitpoint:master Aug 12, 2017
@tautf tautf deleted the pull-list-spell-mistake branch August 12, 2017 17:45
@tautf
Copy link
Contributor Author

tautf commented Aug 12, 2017

@lex111 no i dont i will take a look and take care of it for my next pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants