Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): Add turkish translations #279

Merged
merged 4 commits into from
Sep 1, 2017

Conversation

abdurrahmanekr
Copy link
Contributor

@abdurrahmanekr abdurrahmanekr commented Aug 25, 2017

Hello, I need some friends for Turkish review.
Review request:
@selmansamet
@yusufcakal
@mlelyakan

Copy link

@yusufcakal yusufcakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Güzel bir katkı.

Copy link

@yusufcakal yusufcakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ilgil ideğişiklikler.

privatized: 'privatized',
starred: 'yıldızlı',
pushedTo: '\'a pushlandı',
forked: 'forklandı',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fork edildi.

review_requested: 'inceleme istendi',
review_request_removed: 'inceleme isteği silindi',
submitted: 'gönderildi',
dismissed: 'dismissed',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reddedildi

submitted: 'gönderildi',
dismissed: 'dismissed',
published: 'yayımlandı',
publicized: 'publicized',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halka açıldı

dismissed: 'dismissed',
published: 'yayımlandı',
publicized: 'publicized',
privatized: 'privatized',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kişisel oldu

objects: {
repository: 'repository',
branch: 'branch',
tag: 'tag',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dal ve etiket

shareAction: 'Paylaş',
unwatchAction: 'İzleme',
watchAction: 'İzle',
ownerTitle: 'OWNER',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAHİBİ

unwatchAction: 'İzleme',
watchAction: 'İzle',
ownerTitle: 'OWNER',
contributorsTitle: 'CONTRIBUTORS',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

katkıda bulunanlar (büyük harflerle)

Copy link

@yusufcakal yusufcakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pullRequestEvent: '{{action}} pull request',
pullRequestReviewEvent: '{{action}} pull request review',
pullRequestReviewCommentEvent: '{{action}} on pull request',
pullRequestReviewEditedEvent: '{{action}} their comment on pull request',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

their comment on

This is a lot where there is and not translated, will remain in English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't any idea about the Turkish meaning of these descriptions. I need a little time in order to translate these descriptions. It can be used for a while in that type. So, it will remain in English for a while.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got you, usually and not translated "specific" Git / GitHub terms (not always, but so often
), such as pull request, merge, and even issue. But expressions like "their comment on" better translate.

Copy link
Contributor Author

@abdurrahmanekr abdurrahmanekr Aug 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on PR as soon as possible. Thanks for your suggestions 👍

@housseindjirdeh
Copy link
Member

Thank you so so much @abdurrahmanekr, @yusufcakal, @mlelyakan 🎉 🎉

@abdurrahmanekr Will you prefer to have this PR open until the few translation strings are updated or have this merged in and an open issue to tackle those translation strings at a later point? I'm okay either way :)

Copy link
Member

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some basic things to make Travis happy.

},
events: {
welcomeMessage:
"Hoşgeldiniz! Bu, haber kaynağınızdır - izlediğiniz repository'lerde ve takip ettiğiniz kişilerle ilgili son etkinlikleri takip etmenize yardımcı olur.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use single quotes

},
},
profile: {
orgsRequestApprovalTop: "Tüm organizasyonlarınızı göremiyor musunuz?",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

title: 'Privacy Policy',
effectiveDate: 'Last updated: July 15, 2017',
introduction:
"We're glad you decided to use GitPoint. This Privacy Policy is here to inform you about what we do — and do not do — with our user's data.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

"We're glad you decided to use GitPoint. This Privacy Policy is here to inform you about what we do — and do not do — with our user's data.",
userDataTitle: 'USER DATA',
userData1:
"We do not do anything with your GitHub information. After authenticating, the user's OAuth token is persisted directly on their device storage. It is not possible for us to retrieve that information. We never view a user's access token nor store it whatsoever.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

userData1:
"We do not do anything with your GitHub information. After authenticating, the user's OAuth token is persisted directly on their device storage. It is not possible for us to retrieve that information. We never view a user's access token nor store it whatsoever.",
userData2:
"This means that in no way, shape or form do we ever view, use or share a user's GitHub data. If private data ever becomes visible at any point we will not record or view it. If it happens to be accidentally recorded, we will delete it immediately using secure erase methods. Again, we've set up authentication specifically so that this never happens.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

analyticsInfo1:
'We currently use Google Analytics and iTunes App Analytics to help us measure traffic and usage trends for the GitPoint. These tools collect information sent by your device including device and platform version, region and referrer. This information cannot reasonably be used to identify any particular individual user and no personal information is extracted.',
analyticsInfo2:
"If we happen to include another third party platform to collect stack traces, error logs or more analytics information, we'll make sure that user data remains anonymized and encrypted.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

participatingButton: 'Katılımda',
allButton: 'Tümü',
retrievingMessage: 'Bildirim alınıyor',
noneMessage: "Bu türde hiçbir bildirime sahip değilsiniz",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes

@abdurrahmanekr
Copy link
Contributor Author

@housseindjirdeh, I've translated all the points that are considered important. I think we can merge it for the next release :)

privacyPolicy: 'Gizlilik Politikası',
signOut: 'Çıkış Yap',
},
privacyPolicy: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdurrahmanekr can you translate anything from the policy policy block? It would be great to translate everything, although it is difficult, because a lot of text.

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @abdurrahmanekr :) This really is going to be such an awesome addition to the app.

@housseindjirdeh housseindjirdeh merged commit 203d192 into gitpoint:master Sep 1, 2017
@abdurrahmanekr abdurrahmanekr deleted the tr-translate branch September 1, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants