feat(comment-input): submit comment on clicking on the icon instead text #324
Conversation
lex111
force-pushed
the
comment-button-improvements
branch
from
967f91a
to
e6e303d
Compare
|
Nice thank you for thinking about how we can make the input field a little more user friendly 👍 Definitely in favour of just using the icon as the send button since it feels more natural. However one thing that I liked was having If you think it looks nicer the way it is, only thing I would suggest is adding a little more paddingLeft for the text. Looks a little squeezed to the left side on iOS:
|
|
@housseindjirdeh I understood what you mean, but I removed the left padding, so that there was more space for the text, I would leave it as it is now. Let's find out the opinions of the other contributors 🙌 |
|
Thanks @lex111, I'm okay with leaving the way it is and adding a little more left padding as well (to match the padding on the right hand side of the arrow icon) if everyone likes this as well. Let us know what you think @andrewda @alejandronanez @cameronsamuels etc... |
|
@housseindjirdeh, I think removing the send icon on the left, and replacing the “post” text at the right with the send icon will be good to do (the same thing as the pr description). |
|
I will also explain that I made horizontal indents the same as for other elements, see the screenshot below:
Therefore, if we add more padding, although small, it will no longer be exactly on the grid |
|
@lex111 fair enough, definitely okay with leaving things the way it is now. Will defer the decision to you if you feel like you'll rather have this however :) |
|
@housseindjirdeh can we also merge? |
Now the send icon do nothing, although in many applications the message is sent by clicking on this icon, while the "Send" text is superfluous, so it was deleted. Now there is more free space for the text, which was the main point.